Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ce4aa32 to
2d25f3d
Compare
| // waitForAppDeploy polls until the app reaches a terminal status. Each | ||
| // non-terminal read reports the app status and the newest build status so a | ||
| // long image build is not a silent wait. | ||
| func waitForAppDeploy( |
There was a problem hiding this comment.
suggestion (non-blocking): waitForAppDeploy copies the poll loop of serverlessapi.Client.WaitApp, and WaitApp now has no caller outside its tests. Add a per-poll callback to WaitApp and keep only the build lookup here; this also removes the second hard-coded 2 * time.Second next to defaultAppPollInterval.
| } | ||
| } | ||
|
|
||
| func TestWaitForAppDeploy_ReportsBuildStatus(t *testing.T) { |
There was a problem hiding this comment.
suggestion (non-blocking): The PR says "A build list that cannot be read does not fail the wait", but no test covers it. Add a case where /builds returns 500 and the wait still returns the active app with the no-build message.
There was a problem hiding this comment.
Addressed: TestWaitForAppDeploy_ContinuesWhenBuildsFail covers a 500 from /builds; the wait still returns the active app with the no-build message.
A first deploy sat on one waiting line for the whole image build. The wait now says whether that build is queued or building.
A 500 from /builds must not fail the poll; the status line just omits the build.
2d25f3d to
1a65fb7
Compare
2 participants
Summary
deploy --waitreports the application status and the newest build status while the image build is still running.Test plan
runware serverless deploy ./app.py --id my-app --gpu-type h100 --waitprintsWaiting for application my-app (initializing, build building)...while the build runs