fix(serverless): print endpoints after a first deploy - #134
Conversation
--wait already warned when an update moved an endpoint. A first deploy that becomes active now prints the paths and an invoke example.
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A racing create falls through to UpdateApp but still printed first-deploy endpoints, which can be the outgoing version's paths.
wilsonsilva
left a comment
wilsonsilva
left a comment
There was a problem hiding this comment.
Both fixes look good. Thanks!
## Summary - `deploy --wait` reports the application status and the newest build status while the image build is still running. - The line is printed again only when that status changes. A build list that cannot be read does not fail the wait. ## Test plan - [ ] `runware serverless deploy ./app.py --id my-app --gpu-type h100 --wait` prints `Waiting for application my-app (initializing, build building)...` while the build runs - [ ] The line changes when the build status changes, and the command still exits when the app is active or failed
2 participants
Summary
deploy --waitthat reachesactiveprints the endpoint paths and an invoke example on stderr.--waitstill reports only what the deploy added or removed.Test plan
runware serverless deploy ./app.py --id my-app --gpu-type h100 --waitprintsEndpoints:andInvoke: runware serverless apps invoke ...once the app is active--waitthat does not change paths stays quiet--format jsonstdout is still only the app record