Skip to content

fix(serverless): set secrets and scale knobs on deploy create - #132

Merged
Ryank90 merged 2 commits into
fix/serverless-scale-helpfrom
feat/serverless-deploy-create-flags
Sep 23, 2026
Merged

Ryank90 merged 2 commits into
fix/serverless-scale-helpfrom
feat/serverless-deploy-create-flags

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • deploy can attach organisation secrets at create with --secret NAME or --secret NAME=ENV_VAR, so the first rollout carries them.
  • Create also accepts the scale knobs apps scale already has: --concurrency, --fallback-gpu-type, --min-available-workers, and --available-workers-pct. Passing any of them on an update is rejected.
  • Help and the update error now say volumes are immutable after create.

Test plan

  • A create deploy with --secret ORG_TOKEN and --min-available-workers 1 sends those fields
  • The same flags on an existing app fail before upload, pointing at secrets attach or apps scale
  • --volume on an update says volumes are immutable after create

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4ac10314-c9cd-4ed2-93ec-5a9a7b214101

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Ryank90
Ryank90 force-pushed the feat/serverless-deploy-create-flags branch from 225f0f4 to cfec75b Compare September 22, 2026 15:57
@Ryank90
Ryank90 changed the base branch from rc/serverless to fix/serverless-scale-help September 22, 2026 15:58
A first deploy could not attach an organisation secret or set the worker buffer, concurrency, or fallback GPU, and the help did not say that volumes stay fixed after create.
@Ryank90
Ryank90 force-pushed the feat/serverless-deploy-create-flags branch from cfec75b to d309973 Compare September 22, 2026 18:29
@Ryank90
Ryank90 force-pushed the fix/serverless-scale-help branch from 55e2418 to 6ed36ac Compare September 22, 2026 18:29
Comment thread internal/cmd/serverless/deploy.go
Comment thread internal/cmd/serverless/deploy.go
Comment thread internal/cmd/serverless/deploy.go
…orker percent

An httptest now decodes the create body for secrets and minAvailableWorkers. --available-workers-pct is checked locally so a value outside 0-100 fails before the archive upload.
@Ryank90
Ryank90 merged commit b73fdcd into fix/serverless-scale-help Sep 23, 2026
4 checks passed
@Ryank90
Ryank90 deleted the feat/serverless-deploy-create-flags branch September 23, 2026 21:00

@wilsonsilva wilsonsilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants