Skip to content

fix(serverless): drop activity and errorRate from apps list --sort - #129

Merged
Ryank90 merged 2 commits into
rc/serverlessfrom
fix/serverless-list-sort
Sep 24, 2026
Merged

Ryank90 merged 2 commits into
rc/serverlessfrom
fix/serverless-list-sort

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apps list --sort now accepts only createdAt and name. activity and errorRate were cut from the MVP: the API enum still lists them, but the server returns 422 because those metrics are not collected yet.
  • An unsupported sort is rejected locally, with the error naming the two sorts that work.

Test plan

  • go test ./internal/cmd/serverless/ -run TestParseAppSort
  • runware serverless apps list --help lists createdAt and name only
  • runware serverless apps list --sort activity fails locally and does not call the API

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4812f31b-d8c7-4582-9bea-89f55bf50408

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread internal/cmd/serverless/apps.go Outdated
Comment thread internal/cmd/serverless/apps.go Outdated
Those orderings stay in the API enum, but the server returns 422 until
traffic metrics exist. The CLI only offers createdAt and name.
The allowlist and help now share one constant, so a rename in the OpenAPI enum fails to compile instead of drifting in the flag text.
@Ryank90
Ryank90 force-pushed the fix/serverless-list-sort branch from 1ec1157 to a9c12c1 Compare September 24, 2026 15:03
@Ryank90
Ryank90 merged commit 9b2fafa into rc/serverless Sep 24, 2026
4 checks passed
@Ryank90
Ryank90 deleted the fix/serverless-list-sort branch September 24, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants