Skip to content

fix(serverless): describe apps scale as a version and a rollout - #128

Merged
Ryank90 merged 5 commits into
rc/serverlessfrom
fix/serverless-scale-help
Sep 24, 2026
Merged

Ryank90 merged 5 commits into
rc/serverlessfrom
fix/serverless-scale-help

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apps scale help now says a configuration change records a new version with the same image and rolls the workload, instead of waiting for the next scaler cycle.
  • The GPU-type example no longer says the change applies only to newly created workers.

Test plan

  • runware serverless apps scale --help describes a version and a rollout, and says the command does not wait for it
  • A stopped app is described as applying the change on resume, and an in-flight rollout as 409

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 80a93a40-e632-4524-827e-2f85c4c4204f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Ryank90
Ryank90 force-pushed the fix/serverless-scale-help branch from 65e7b3d to 55e2418 Compare September 22, 2026 15:57
@Ryank90
Ryank90 changed the base branch from rc/serverless to fix/serverless-gpus-per-worker September 22, 2026 15:58
Comment thread internal/cmd/serverless/apps_scale.go Outdated
@Ryank90
Ryank90 force-pushed the fix/serverless-gpus-per-worker branch from 504905c to cd80f61 Compare September 22, 2026 18:29
@Ryank90
Ryank90 force-pushed the fix/serverless-scale-help branch from 55e2418 to 6ed36ac Compare September 22, 2026 18:29
@Ryank90
Ryank90 force-pushed the fix/serverless-gpus-per-worker branch from cd80f61 to d50116a Compare September 24, 2026 14:39
Base automatically changed from fix/serverless-gpus-per-worker to rc/serverless September 24, 2026 14:54
@Ryank90
Ryank90 force-pushed the fix/serverless-scale-help branch from b73fdcd to 9994eb7 Compare September 24, 2026 15:00
Ryank90 and others added 5 commits September 24, 2026 17:00
Help said a configuration change waited for the next scaler cycle. The API
records a new version with the same image and rolls the workload.
Co-authored-by: Wilson Silva <wilson.dsigns@gmail.com>
A first deploy could not attach an organisation secret or set the worker buffer, concurrency, or fallback GPU, and the help did not say that volumes stay fixed after create.
…orker percent

An httptest now decodes the create body for secrets and minAvailableWorkers. --available-workers-pct is checked locally so a value outside 0-100 fails before the archive upload.
@Ryank90
Ryank90 force-pushed the fix/serverless-scale-help branch from 9994eb7 to c51c0c3 Compare September 24, 2026 16:41
@Ryank90
Ryank90 merged commit c26f570 into rc/serverless Sep 24, 2026
4 checks passed
@Ryank90
Ryank90 deleted the fix/serverless-scale-help branch September 24, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants