fix(serverless): reject an invalid --gpus-per-worker before upload - #127
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
62a340b to
504905c
Compare
504905c to
cd80f61
Compare
Create and scale only accept 1, 2, 4, or 8. Deploy was sending any integer and learning that from a 422 after the source archive had already uploaded.
One slice drives the help, the error, and the local check, and deploy rejects an invalid value before it builds the archive.
cd80f61 to
d50116a
Compare
Summary
--gpus-per-workervalues other than 1, 2, 4, or 8 ondeployandapps scalebefore any request is sent.Test plan
go test ./internal/cmd/serverless/ -run 'ValidateGPUsPerWorker|WorkerConfigPatchFromFlags'runware serverless deploy ./app.py --id my-app --gpu-type h100 --gpus-per-worker 3fails locally and does not upload--gpus-per-worker 2and4are still accepted