Skip to content

feat(serverless): filter live workers and wait for deploy - #112

Merged
Ryank90 merged 1 commit into
feat/drop-usefrom
feat/workers-state-deploy-wait
Sep 7, 2026
Merged

Ryank90 merged 1 commit into
feat/drop-usefrom
feat/workers-state-deploy-wait

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Wire apps workers --state live|all to the existing listWorkers query. The CLI previously only sent --status; --state live drops terminal stopped rows, and --state live --status stopped is a 422 from the API.
  • Add --wait / --poll-interval on serverless deploy. WaitApp polls getApp until the app is active or failed (also stops on stopped/deleting/deleted so a wait cannot spin forever). A failed wait prints the last app snapshot, then surfaces the latest listBuilds error when one exists.
  • WaitApp is the reusable waiter for a later redeploy (PATCH appSource); this PR does not add that route.

Test plan

  • runware serverless apps workers my-app --state live omits stopped rows
  • runware serverless apps workers my-app --state live --status stopped returns API 422
  • Next-page hint after --state live includes --state live
  • runware serverless deploy ... --wait returns after the app is active
  • A failed first build with --wait exits non-zero and includes the build error when listBuilds has one
  • minWorkers=0 can still be active with no live worker

@coderabbitai

coderabbitai Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 667c5f3c-693b-4d27-83f5-5482002fb51d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Expose the existing listWorkers state query and poll getApp after create
so a deploy can block until the app is active or failed.
@Ryank90
Ryank90 force-pushed the feat/workers-state-deploy-wait branch from e6214d5 to fef2b2c Compare September 7, 2026 09:57
@Ryank90
Ryank90 merged commit 697adad into rc/serverless Sep 7, 2026
7 checks passed
@Ryank90
Ryank90 deleted the feat/workers-state-deploy-wait branch September 7, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant