Skip to content

fix(cask): replace deprecated postflight hook - #1

Closed
emmmile wants to merge 1 commit into
mainfrom
fix/postflight-steps
Closed

emmmile wants to merge 1 commit into
mainfrom
fix/postflight-steps

Conversation

@emmmile

@emmmile emmmile commented Sep 15, 2026 •

Copy link
Copy Markdown

Replaces the deprecated postflight Cask hook with postflight_steps, preserving the existing macOS quarantine-removal command and eliminating Homebrew's deprecation warning. Deliberately omitted: no version, artifact, or installation-behavior changes.

Basically fixes this warning:

Warning: Calling `postflight` is deprecated! Use `postflight_steps` instead.
Please report this issue to the runware/homebrew-tap tap (not Homebrew/* repositories), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/runware/homebrew-tap/Casks/runware.rb:36

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ac68e1fa-fac4-438e-a8c4-8cb2ead43283

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@emmmile
emmmile requested review from danmrichards and a lite review from Copilot September 15, 2026 12:51
@emmmile
emmmile marked this pull request as ready for review September 15, 2026 12:51
@emmmile
emmmile removed the request for review from danmrichards September 15, 2026 12:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The hook uses unsupported DSL constructs, and the generated source must also be updated.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Replaces the deprecated postflight Cask hook with postflight_steps while preserving quarantine removal.

Changes:

  • Updates the Cask lifecycle hook.
  • Retains macOS quarantine-removal logic.
File summaries
File Summary
Casks/runware.rb Updates the generated Cask hook; the implementation requires the supported step DSL and generator source update.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Casks/runware.rb
Comment on lines +36 to 39
postflight_steps do
if OS.mac?
system_command "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "#{staged_path}/runware"]
end
Comment thread Casks/runware.rb
binary "runware"

postflight do
postflight_steps do
@emmmile

emmmile commented Sep 15, 2026

Copy link
Copy Markdown
Author

Closing: this Cask is generated by GoReleaser, so a tap-only edit would be overwritten on the next release. The durable fix belongs in the release generator/update path.

@emmmile emmmile closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants