Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The hook uses unsupported DSL constructs, and the generated source must also be updated.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Replaces the deprecated postflight Cask hook with postflight_steps while preserving quarantine removal.
Changes:
- Updates the Cask lifecycle hook.
- Retains macOS quarantine-removal logic.
File summaries
| File | Summary |
|---|---|
Casks/runware.rb |
Updates the generated Cask hook; the implementation requires the supported step DSL and generator source update. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| postflight_steps do | ||
| if OS.mac? | ||
| system_command "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "#{staged_path}/runware"] | ||
| end |
| binary "runware" | ||
|
|
||
| postflight do | ||
| postflight_steps do |
|
Closing: this Cask is generated by GoReleaser, so a tap-only edit would be overwritten on the next release. The durable fix belongs in the release generator/update path. |
Replaces the deprecated postflight Cask hook with postflight_steps, preserving the existing macOS quarantine-removal command and eliminating Homebrew's deprecation warning. Deliberately omitted: no version, artifact, or installation-behavior changes.
Basically fixes this warning: