fix(ci): restore full-suite after verification request + lucide mock gaps#2332
Merged
Conversation
…re landings - Stub TaskStore verification request APIs on executor test mocks (default null) - Add NativeStructurePreview lucide icons to TaskDetailModal shared mock - Quarantine grok process-lifecycle stress flake (15s timeout under full-suite load)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTest mocks now cover verification-request APIs and additional dashboard icons. The Grok process-lifecycle test is excluded from Vitest and added to the quarantine ledger. The dashboard adds ChangesTest Harness Compatibility
Test Quarantine
Dashboard html2canvas Support
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR restores green full-suite CI shards by addressing three independent root causes: missing
Confidence Score: 5/5Safe to merge — all changes are test infrastructure fixes with one incidental lock-file peer-resolution shift worth a quick confirmation. The executor stub additions are consistent between the shared helper and the inline store, the lucide mock additions are correctly scoped to the shared helper file, and the grok-runtime quarantine satisfies the full AGENTS.md protocol. The only noteworthy item is the zod@3→4 peer-resolution shift in pnpm-lock.yaml that is unrelated to any of the described changes. pnpm-lock.yaml — the zod peer-resolution shift for @earendil-works and @modelcontextprotocol/sdk packages should be confirmed as intentional. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["execute() called"] --> B["getAgentLogCount stub"]
B --> C{"task.deletedAt?"}
C -->|yes| D["warn + release lock — returns early"]
C -->|no| E["getTaskVerificationRequestAsync stub"]
E --> F{"pending request?"}
F -->|"null (default)"| G["normal execution path"]
F -->|"non-null"| H["claimTaskVerificationRequest stub"]
H --> I["finishTaskVerificationRequest stub"]
I --> G
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["execute() called"] --> B["getAgentLogCount stub"]
B --> C{"task.deletedAt?"}
C -->|yes| D["warn + release lock — returns early"]
C -->|no| E["getTaskVerificationRequestAsync stub"]
E --> F{"pending request?"}
F -->|"null (default)"| G["normal execution path"]
F -->|"non-null"| H["claimTaskVerificationRequest stub"]
H --> I["finishTaskVerificationRequest stub"]
I --> G
Reviews (2): Last reviewed commit: "fix(FN-ci): html2canvas ambient types + ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
… soft-delete tests
Collaborator
Author
|
Automated fix: ambient html2canvas types for typecheck + createTaskVerificationRequest stub. |
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main Full Suite shards have been red after recent landings. Root causes:
execute()now pollsgetTaskVerificationRequestAsync(chat-enqueued verification). SharedcreateMockStore()(and soft-delete inline store) lacked the method, so nearly every execute-path suite failed withis not a function.NativeStructurePreviewimportsMap/Lightbulb/BarChart3/Target/CircleAlertfrom lucide; the shared TaskDetail lucide mock omitted them, so suites failed at import.Test plan
executor-task-done-blocked,executor-fast-mode-workflows, concurrent-execute raceexecutor-step-session, plan-only scope leak, review-step indexingTaskDetailModal.create-pr+TaskDetail.mobile-transitionSummary by CodeRabbit
html2canvassupport in the dashboard to enable HTML-to-canvas rendering needed for visual structure previews.