Skip to content

Correct eql? deprecation warning #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yukideluxe merged 3 commits into from
Sep 23, 2026
+2 −1
Merged

Correct eql? deprecation warning #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
604c67e
Correct eql? method warning
peter-j-fortuna Sep 22, 2026
dd836f5
typo
peter-j-fortuna Sep 22, 2026
2ec53b5
Update CHANGELOG
peter-j-fortuna Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Fix `Money::Currency.reset!` keeping the cached key set, so a currency registered before the reset was still accepted by `Money::Currency.new` and raised `NoMethodError` instead of `UnknownCurrency`
- Fix `Money::Bank::VariableExchange#import_rates` parsing `:json` with `JSON.load`, which instantiates any class named by a `json_class` key; it now uses `JSON.parse`
- Fix deprecation warning for eql?

## 7.1.1

Expand Down
2 changes: 1 addition & 1 deletion lib/money/money/arithmetic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def -@
# @see Money.strict_eql_compare
def eql?(other)
if other.is_a?(Money)
if !Money.strict_eql_compare && fractional == 0 && other.fractional == 0
if !Money.strict_eql_compare && fractional == 0 && other.fractional == 0 && currency != other.currency
warn "[DEPRECATION] Comparing 0 #{currency} with 0 " \
"#{other.currency} using `#eql?` will return false in " \
"future versions of Money. Opt-in to the new behavior by " \
Expand Down
Loading