Ship apps/docs in the app image so setup docs render#754
Merged
Conversation
The setup-flow documentation added in #724 reads apps/docs/*.mdx from disk at request time, but .dockerignore excluded apps/docs from the Docker build context and the app Dockerfile never copied it into any stage. getDocsPage() swallows the read failure and returns null, and the setup page treats null as "no docs for this step", so the panel silently disappeared in every Docker deployment while working in local dev checkouts. Include apps/docs in the build context, copy it into the build stage (which also lets pnpm docs:assets actually sync the logo assets it was silently skipping), and ship it in the runtime image next to apps/web where the server resolves ../docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contextual setup documentation from #724 doesn't render in any deployed environment: .dockerignore excludes apps/docs from the Docker build context and the app Dockerfile never copies it, while apps/web/src/lib/docs-content.ts reads the MDX at request time from ../docs and silently returns null on failure — so the panel just disappears. Works in local dev because the repo checkout has apps/docs.
Fix: include apps/docs in the build context, copy it into the build stage (also un-breaks the silent pnpm docs:assets logo sync) and into the runtime image next to apps/web where the server (cwd /roomote/apps/web) resolves ../docs.
Verified locally: built the base stage with the new context and confirmed /roomote/apps/docs is present. pnpm install is unaffected (docs land after install). apps/docs is 79 small MDX/config files, so image-size impact is negligible.
After merge, the develop build auto-rolls to the preview fleet — verify by opening a setup step on a preview tenant.