Promote v0.19.0 to production#737
Merged
Merged
Conversation
Regression tests for the fix that landed in #727: enqueueSnapshotResume inherits sourceControlProvider/sourceControlHost from the source run's payload when the resume entry point did not copy them, and keeps an explicitly provided provider untouched. Without the inheritance, resumed runs on non-GitHub providers (Azure DevOps, Gitea, Bitbucket) resolved the repository against the GitHub default and failed workspace preparation with "Repository not found". Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…733) * feat(notifications): retire PR review offers when a reply supersedes them A typed reply in the thread means the person chose their own response, so the offer's buttons must die instead of lingering. Pending offers now carry a per-conversation index and the posted message id; when a follow-up message is routed into the task (live queue or snapshot resume), all pending offers for that conversation are claimed atomically and the Slack message is rewritten without its buttons ("Answered with a reply in the thread."). Telegram clears the inline keyboard; Discord offers are claimed so clicks report already-handled (component editing not wired yet). Late clicks on retired offers get the existing already-handled reply. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test: cover retire helper in discord/telegram sdk mocks, harden discord helper Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Stamp inheritance on snapshot resume only consulted the immediate source run. When that run is itself a resume created before inheritance existed, its rebuilt payload has no stamps even though the original run does, so a second resume of a legacy non-GitHub task still fell back to the GitHub default and failed workspace preparation. enqueueSnapshotResume already walks the sourceRunId chain to find the original run for model selection; reuse that walk to pick up missing source-control stamps from the nearest ancestor that has them. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
) Team feedback: the button labels did not make the one-time vs ongoing distinction obvious, and an explainer paragraph read as too much. The buttons now answer the question directly — "Resolve these issues" (the feedback in this notification), "Resolve all issues" (these and every future one on this PR), "Dismiss" — and the triage prompt phrases the question with the same resolve verb so message and buttons stay congruent. Confirmations follow the same voice. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
Contributor
|
No new code issues found. See task
Reviewed 1be9a42 |
Contributor
|
Addressed all three reported issues in 1be9a42: review-action attachment and thread-wide retirement now use atomic Redis scripts, and explicit snapshot-resume providers no longer inherit a source host. Targeted tests and static checks passed; visual proof is not applicable to these backend behaviors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote v0.19.0
Frozen at
2763cc2759faec43900d5f7f11221622a08e0b28— the commit where0.19.0was versioned. Commits merged todevelopafter that point ship in the next release.v0.19.0and triggers the existing GHCRv*image publish (latestchannel).release/v0.19.0branch can be deleted after this PR merges.Changelog
0.19.0 (2026-07-23)
This release makes pull-request review feedback clearer and safer to handle across chat, with more reliable task resumption.
Highlights
Minor changes
Patch changes