Closed: opened in error#961
Closed
raytracerfvf wants to merge 1 commit intoRocketPy-Team:developfrom
Closed
Conversation
The cubic Hermite root-finder filters with a strict open interval (0, t1). When numerical noise places the ground crossing at a boundary (e.g. a rocket settling under parachute), no candidate survives and valid_t_root[0] raises IndexError. Fall back to t1 in that case -- solution[-1] is at or below ground by then, so it is the correct side of the crossing.
Author
|
Closing — opened by mistake. Will revisit later if appropriate. |
raytracerfvf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by mistake and has been closed. Please disregard.