feat(ui-kit): add header, video, markdown blocks and datetimepicker/number/email/url elements#41129
feat(ui-kit): add header, video, markdown blocks and datetimepicker/number/email/url elements#41129ggazzo wants to merge 5 commits into
Conversation
Slack Block Kit parity. Renders a plain_text title as an h2 heading. Available on message, modal and contextual bar surfaces, plus Storybook playground stories/payloads.
Slack Block Kit parity for form inputs. number_input supports min/max/decimal constraints; email_text_input and url_text_input use the matching native input types. Valid inside input blocks, with Storybook playground stories/payloads.
Slack Block Kit parity. Combined date and time picker backed by a native datetime-local input. Valid inside input and actions blocks, with Storybook playground story/payload.
Slack Block Kit parity. Embeds a titled video via an iframe with optional description and title link. Available on message, modal and contextual bar surfaces, with Storybook playground stories/payloads.
Slack Block Kit parity. Renders a top-level GitHub-flavored markdown string through the shared message-parser markup. Available on message, modal and contextual bar surfaces, with Storybook playground stories/payloads.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41129 +/- ##
===========================================
- Coverage 69.16% 69.10% -0.06%
===========================================
Files 3433 3438 +5
Lines 132323 132488 +165
Branches 23087 23093 +6
===========================================
+ Hits 91518 91557 +39
- Misses 37455 37581 +126
Partials 3350 3350
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 participant
Proposed changes (including videos or screenshots)
Adds new UiKit layout blocks and input elements to
@rocket.chat/ui-kitand their Fuselage renderers in@rocket.chat/fuselage-ui-kit:Includes the block/element type definitions,
isInputBlockElement/isActionsBlockElementguards, surface renderer wiring (message, modal, contextual bar), and Storybook payloads/stories for the new blocks.Issue(s)
Steps to test or reproduce
yarn workspace @rocket.chat/fuselage-ui-kit storybookMessageandModalstories and check the new header, video, markdown blocks and the datetimepicker / number / email / url inputs.Further comments
Extracted into its own branch; no functional dependency on other in-flight work.