Fix distance attenuation in lidar intensity - #368
Draft
Daniiiil1 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Daniil Mordanov <153565951+Daniiiil1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The ray-tracing path scaled intensity by the incidence-angle cosine but did not account for geometric spreading. The reflectivity node already multiplied intensity by squared distance, assuming that intensity contained the reciprocal factor. As a result, intensity did not decay with range and derived reflectivity increased with distance.
Validation
clang-format 14.0.6 --dry-run --Werroron all changed C++/CUDA filesgit diff --checkThe CUDA/OptiX test suite could not be executed locally because the development machine does not have an NVIDIA GPU or CUDA/OptiX toolchain. The added tests are intended to run in the repository's supported NVIDIA environment.
Fixes #367