Keep switches available when Disable Available Check is on - #523
Merged
Merged
Conversation
Since #508, the xfan, lights, health, powersave, 8 degC heat, sleep and air switches took their availability from `_device_online`. With "Disable Available Check" on, the climate entity never sets that field, so it stays None and the seven switches were unavailable for good. The climate entity itself stayed available, because its `available` checks the option first. `_prop_supported()` now uses the climate entity's `available`, so the switches follow the same rule as the climate entity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #508 (released in 4.0.7), users with Disable Available Check turned on see seven switches as unavailable all the time: xfan, lights, health, powersave, 8 degC heat, sleep and air. The climate entity itself still works.
Cause
_prop_supported()inswitch.pyreturnsdevice._device_online. With the option on,climate.pynever sets that field, so it staysNone. The climate entity's ownavailablechecks the option first, so only the switches were affected. Before #508 these switches were always available.Change
_prop_supported()now returns the climate entity'savailable. The switches then follow the same rule as the climate entity: always available with the option on, and online or offline otherwise. Hiding unsupported props (an empty value after the first sync) is unchanged.Testing
On my fake-device harness, which drives the real
climate.pyandswitch.py:None).