Repository navigation
fix: suspend with Ctrl-Z - #355
Open
HackAttack wants to merge 1 commit into
Open
HackAttack wants to merge 1 commit into
HackAttack wants to merge 1 commit into
Conversation
Ctrl-Z does nothing in leaf: raw mode delivers it as a key press, so the shell's job control never sees it. Handle Ctrl-Z as a key: leave the TUI through the same suspend/resume path the external editor already uses, stop the job, and redraw on `fg`. A job sent to the background with `bg` stays stopped until `fg`, because re-entering raw mode from the background stops it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl-Z does nothing in leaf: raw mode delivers it as a key press, so the shell's job control never sees it.
Handle Ctrl-Z as a key: leave the TUI through the same suspend/resume path the external editor already uses, stop the job, and redraw on
fg. A job sent to the background withbgstays stopped untilfg, because re-entering raw mode from the background stops it again.This fixes #297 in a way that hopefully overcomes the objections of #296 by taking a smaller approach:
TerminalSession::suspend/resume, so there is no second copy of that logic