Repository navigation
fix: upgrade CLI CI to Python 3.11.18 (DEFVULN-53892) - #23
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Test of Human Presence
Approved by adgupta21. Commit: 383e081 Pushing another commit replaces this comment and requires approval for the new head SHA. |
adgupta21
left a comment
There was a problem hiding this comment.
This comment is added by Claude using /claude-marketplace/plugins/integrations-platform/pr-reviewer.
No findings. S0: 0, S1: 0, S2: 0, S3: 0, S4: 0. No inline comments.
Intent vs. code: matches. test.yml and the mypy job in lint.yml now run setup-python at 3.11.18 before python -m pip install poetry. The ruff job gains an explicit setup-python at 3.11.18; it previously used the runner default.
Checked
3.11.18exists in theactions/python-versionsmanifest, sosetup-pythoncan resolve it.ruff,pytestandmypyare all SUCCESS on head383e081.run_ruff.shusespython3and installsruff==0.3.3via pip. Aftersetup-python,python3is 3.11.18.ruff.tomlhastarget-version = "py310", which is fine on 3.11.- Poetry is now installed into the selected interpreter. Previously it was installed on the runner Python before selection.
Interfaces and REST contracts
Interfaces changed: none
REST contracts changed: none
| Interface | Kind | File:line | Change | Callers / implementers | Backward compatible | Why |
|---|---|---|---|---|---|---|
| none |
All interfaces backward compatible: yes
All REST contracts backward compatible: yes
Functionality: matches the PR description
Client impact: none. Only GitHub Actions workflow runtimes change.
Backward compatible: yes
Observations (not findings)
- The declared Python range still includes 3.10 (
pyproject.toml^3.10,DEVELOPER.MD:5,ruff.tomlpy310,rippling_cli/utils/build_utils.py:120), but no CI job now exercises 3.10. The PR description already discloses this; raising the floor is a package-contract decision outside this ticket. - The exact patch pin
3.11.18needs manual bumps (also disclosed). - Human-presence approval is still pending for the head SHA.
Recommendation: LGTM. No code findings.
Product review: not applicable (CI-only change). Skeptic pass: NOT RUN.
Summary
DEFVULN-53892: CLI CI still selects Python 3.10 after its 1 October 2026 end of life. Use supported Python 3.11.18 for pytest, mypy, and Ruff, and initialize it before installing Poetry.
Evidence
383e081f36e086ca0f8f2e601301ae904a5d3b40, with logs explicitly confirming CPython 3.11.18. pytest: dependency installation succeeded and 1 test passed. mypy: dependency installation succeeded and 39 source files passed. Ruff: all checks passed.Caller audit
Datadog repository-tag logs did not establish CI usage; GitHub Actions logs provide direct execution evidence. Production endpoint request metrics and ALL_MODEL_EXCEPTIONS are inapplicable to these CI-only changes.
Honest gap report
Closes the repository-owned workflows' Python 3.10 selection and makes Ruff's runtime explicit. Package Python requirements, generated Flux projects, customer installations, and published binaries are unchanged. Existing pytest coverage is a single help-command smoke test. Exact runtime patch pins require future maintenance.
Test plan
git diff --checkpassed.Merge Danger
Door: Two-way. Blast Radius: CI.
Dependency/tool compatibility can affect checks. The CLI's package requirements and runtime behavior do not change. Changing CI removes Python 3.10 test coverage without changing the package's declared Python range.
Code-owner review is requested. The human-presence check is pending; this PR remains a draft. The local pre-push hook reported TruffleHog unavailable and skipped its secret scan; the final two-file diff was manually inspected.
Rollback plan
Revert this workflow-only commit to restore prior CI behavior; doing so restores the EOL runtime exposure. No data migration or service deployment is involved. After merge, verify a default-branch CI run and request Security remediation validation; merge alone does not establish runtime execution.
Note
Low Risk
Workflow-only CI changes; no application runtime, auth, or production deployment impact beyond how checks run on PRs.
Overview
Bumps GitHub Actions lint and test jobs from Python 3.10 to 3.11.18 (DEFVULN-53892) so CI runs on a supported interpreter after 3.10 EOL.
The Ruff job now pins Python via
actions/setup-pythonbefore./run_ruff.shinstead of relying on the runner default. pytest and mypy jobs install Poetry only after selecting 3.11.18, usingpython -m pip install poetryinstead of a barepip install poetry.Reviewed by Cursor Bugbot for commit 383e081. Configure here.