Skip to content

fix: upgrade CLI CI to Python 3.11.18 (DEFVULN-53892) - #23

Merged
adgupta21 merged 1 commit into
mainfrom
codex/defvuln-53892-python-ci
Nov 11, 2026
Merged

adgupta21 merged 1 commit into
mainfrom
codex/defvuln-53892-python-ci

Conversation

@adgupta21

@adgupta21 adgupta21 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

DEFVULN-53892: CLI CI still selects Python 3.10 after its 1 October 2026 end of life. Use supported Python 3.11.18 for pytest, mypy, and Ruff, and initialize it before installing Poetry.

- CI: Python 3.10 for pytest/mypy; runner-default Python for Ruff
+ CI: Python 3.11.18 for pytest, mypy, and Ruff
- Install Poetry before selecting Python
+ Select Python, then install Poetry with python -m pip

Evidence

  • Before: Default branch d971ff3 selects Python 3.10 in both workflows. Test run 41777543366 on 4 November 2026 ran CPython 3.10.22 and passed its single help-command test after upstream EOL.
  • After: All three GitHub Actions jobs passed on head 383e081f36e086ca0f8f2e601301ae904a5d3b40, with logs explicitly confirming CPython 3.11.18. pytest: dependency installation succeeded and 1 test passed. mypy: dependency installation succeeded and 39 source files passed. Ruff: all checks passed.
  • Verdict: Confirmed EOL runtime exposure in CI; no specific CVE exploitation or production compromise established.
  • Attack path / exposure: Pull request or manual workflow dispatch → GitHub runner → unsupported interpreter → project/dependency execution. No authorization gate or production endpoint changes.

Caller audit

Consumer File Effect
Ruff .github/workflows/lint.yml Explicit supported interpreter replaces implicit runner Python
mypy .github/workflows/lint.yml Supported interpreter selected before Poetry installation
pytest .github/workflows/test.yml Supported interpreter selected before Poetry installation

Datadog repository-tag logs did not establish CI usage; GitHub Actions logs provide direct execution evidence. Production endpoint request metrics and ALL_MODEL_EXCEPTIONS are inapplicable to these CI-only changes.

Honest gap report

Closes the repository-owned workflows' Python 3.10 selection and makes Ruff's runtime explicit. Package Python requirements, generated Flux projects, customer installations, and published binaries are unchanged. Existing pytest coverage is a single help-command smoke test. Exact runtime patch pins require future maintenance.

Test plan

  • Ruby YAML parsing and assertions: exactly the existing three jobs, Python 3.11.18 selected before every run step, Poetry installed through the selected Python, no 3.10 workflow selection. git diff --check passed.
  • Dependency installation and pytest on Python 3.11.18: 1 passed in 0.23s.
  • mypy on Python 3.11.18: no issues in 39 source files; Ruff: all checks passed.
  • GitHub Actions Test and both Lint jobs passed on PR head 383e081; all three job logs confirm CPython 3.11.18.
  • I take full responsibility for this code and its quality, whether written by me or with AI.

Merge Danger

Door: Two-way. Blast Radius: CI.

Dependency/tool compatibility can affect checks. The CLI's package requirements and runtime behavior do not change. Changing CI removes Python 3.10 test coverage without changing the package's declared Python range.

Code-owner review is requested. The human-presence check is pending; this PR remains a draft. The local pre-push hook reported TruffleHog unavailable and skipped its secret scan; the final two-file diff was manually inspected.

Rollback plan

  • Check this box if this PR can be safely reverted.

Revert this workflow-only commit to restore prior CI behavior; doing so restores the EOL runtime exposure. No data migration or service deployment is involved. After merge, verify a default-branch CI run and request Security remediation validation; merge alone does not establish runtime execution.


Note

Low Risk
Workflow-only CI changes; no application runtime, auth, or production deployment impact beyond how checks run on PRs.

Overview
Bumps GitHub Actions lint and test jobs from Python 3.10 to 3.11.18 (DEFVULN-53892) so CI runs on a supported interpreter after 3.10 EOL.

The Ruff job now pins Python via actions/setup-python before ./run_ruff.sh instead of relying on the runner default. pytest and mypy jobs install Poetry only after selecting 3.11.18, using python -m pip install poetry instead of a bare pip install poetry.

Reviewed by Cursor Bugbot for commit 383e081. Configure here.

Co-Authored-By: Codex <noreply@openai.com>
@adgupta21 adgupta21 self-assigned this Nov 9, 2026
@adgupta21 adgupta21 added the codex Changes authored with Codex label Nov 9, 2026
@adgupta21
adgupta21 requested a review from a team November 9, 2026 17:09
@adgupta21
adgupta21 marked this pull request as ready for review November 11, 2026 05:58
@tohp-human-presence

tohp-human-presence Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Test of Human Presence

A human approval is required for the current head commit.

Approved by adgupta21.

Commit: 383e081

Pushing another commit replaces this comment and requires approval for the new head SHA.

@adgupta21 adgupta21 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is added by Claude using /claude-marketplace/plugins/integrations-platform/pr-reviewer.

No findings. S0: 0, S1: 0, S2: 0, S3: 0, S4: 0. No inline comments.

Intent vs. code: matches. test.yml and the mypy job in lint.yml now run setup-python at 3.11.18 before python -m pip install poetry. The ruff job gains an explicit setup-python at 3.11.18; it previously used the runner default.

Checked

  • 3.11.18 exists in the actions/python-versions manifest, so setup-python can resolve it.
  • ruff, pytest and mypy are all SUCCESS on head 383e081.
  • run_ruff.sh uses python3 and installs ruff==0.3.3 via pip. After setup-python, python3 is 3.11.18. ruff.toml has target-version = "py310", which is fine on 3.11.
  • Poetry is now installed into the selected interpreter. Previously it was installed on the runner Python before selection.

Interfaces and REST contracts
Interfaces changed: none
REST contracts changed: none

Interface Kind File:line Change Callers / implementers Backward compatible Why
none

All interfaces backward compatible: yes
All REST contracts backward compatible: yes

Functionality: matches the PR description
Client impact: none. Only GitHub Actions workflow runtimes change.
Backward compatible: yes

Observations (not findings)

  • The declared Python range still includes 3.10 (pyproject.toml ^3.10, DEVELOPER.MD:5, ruff.toml py310, rippling_cli/utils/build_utils.py:120), but no CI job now exercises 3.10. The PR description already discloses this; raising the floor is a package-contract decision outside this ticket.
  • The exact patch pin 3.11.18 needs manual bumps (also disclosed).
  • Human-presence approval is still pending for the head SHA.

Recommendation: LGTM. No code findings.

Product review: not applicable (CI-only change). Skeptic pass: NOT RUN.

@adgupta21
adgupta21 merged commit 5fd2831 into main Nov 11, 2026
5 checks passed
@adgupta21
adgupta21 deleted the codex/defvuln-53892-python-ci branch November 11, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Changes authored with Codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants