Repository navigation
Pin certifi 2026.10.19 (DEFVULN-51432) - #22
Merged
Merged
Conversation
DEFVULN-51432 Co-authored-by: Cursor <cursoragent@cursor.com>
The pyproject pin and poetry.lock are the fix. The bundle assertion only locks a version string. Co-authored-by: Cursor <cursoragent@cursor.com>
Test of Human Presence
Approved by adgupta21. Commit: 8eaca7b Pushing another commit replaces this comment and requires approval for the new head SHA. |
AasthaTiwari
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
certifito2026.10.19sopoetry installno longer trusts emSign ECC Root CA - G3, the eMudhra root named in the incident advisory.requestsalready allowscertifi>=2017.4.17. Only the lock entry and content hash change besides the pin.Security Remediation: DEFVULN-51432
Verdict & Root Cause
Rippling/rippling-cli@55baed17(poetry.lock,certifi2024.2.2)requestsdefault CA bundle →certifi2024.2.2 still trusts emSign ECC Root CA - G3 → a certificate chaining through the compromised eMudhra intermediates can be acceptedcertifi2024.7.4, which still has that root.Fix Summary
certifi = "2026.10.19"and regeneratedpoetry.lock.ALL_MODEL_EXCEPTIONS: Not listed. This is a CLI lockfile, not a rippling-main route.Caller & Blast-Radius Audit
APIClient.make_requestrippling-cliOAuthToken.exchange_for_tokenrippling-clifile_utilsdownloadrippling-clihomebrew-ripplingrippling-mainflux_codespace.pyrippling-apps/temp-rippling-cli, and pip ignorespoetry.lockHonest Gap Report
poetry installfrom this repo usescertifi2026.10.19, which drops emSign ECC Root CA - G3.static-assets.ripplingcdn.com/cli/rippling-cli.0.1.0.tar.gzstill bundles the 2024.2.2 CA file.rippling-apps/temp-rippling-cliis still oncertifi2024.2.2. This PR does not republish either artifact.certifi2026.10.23 also drops unaffected eMudhra roots, so this pin stays on the advisory version.Test Plan
Rollback Plan
Revert this PR. No schema or data migration.
Made with Cursor
Note
Low Risk
Dependency pin and lockfile update with a regression test; no application logic changes beyond TLS trust roots for local CLI installs.
Reviewed by Cursor Bugbot for commit 9423be3. Configure here.