Skip to content

Pin certifi 2026.10.19 (DEFVULN-51432) - #22

Merged
adgupta21 merged 2 commits into
mainfrom
DEFVULN-51432
Nov 4, 2026
Merged

adgupta21 merged 2 commits into
mainfrom
DEFVULN-51432

Conversation

@adgupta21

@adgupta21 adgupta21 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin certifi to 2026.10.19 so poetry install no longer trusts emSign ECC Root CA - G3, the eMudhra root named in the incident advisory.
  • requests already allows certifi>=2017.4.17. Only the lock entry and content hash change besides the pin.

Security Remediation: DEFVULN-51432

Verdict & Root Cause

  • Ticket: DEFVULN-51432
  • Verified at: Rippling/rippling-cli@55baed17 (poetry.lock, certifi 2024.2.2)
  • Attack Path Blocked: developer CLI HTTPS via requests default CA bundle → certifi 2024.2.2 still trusts emSign ECC Root CA - G3 → a certificate chaining through the compromised eMudhra intermediates can be accepted
  • Sibling Precedent: none on this repo. Dependabot PR Bump the pip group across 1 directory with 3 updates #17 only reaches certifi 2024.7.4, which still has that root.

Fix Summary

  • Direct pin certifi = "2026.10.19" and regenerated poetry.lock.
  • ALL_MODEL_EXCEPTIONS: Not listed. This is a CLI lockfile, not a rippling-main route.

Caller & Blast-Radius Audit

Caller Repo Auth Tier 90d Telemetry Affected?
APIClient.make_request rippling-cli developer CLI n/a, local process Yes — uses the lockfile bundle
OAuthToken.exchange_for_token rippling-cli developer CLI n/a Yes
file_utils download rippling-cli developer CLI n/a Yes
Homebrew formula homebrew-rippling installed binary n/a No — installs the CDN tarball, not this lockfile
Flux codespace setup rippling-main flux_codespace.py pip git install n/a No — installs rippling-apps/temp-rippling-cli, and pip ignores poetry.lock

The only trust removed is emSign ECC Root CA - G3. Public roots used for normal Rippling TLS stay in the bundle.

Honest Gap Report

  • Closes: poetry install from this repo uses certifi 2026.10.19, which drops emSign ECC Root CA - G3.
  • Residual / Follow-ups: The published tarball static-assets.ripplingcdn.com/cli/rippling-cli.0.1.0.tar.gz still bundles the 2024.2.2 CA file. rippling-apps/temp-rippling-cli is still on certifi 2024.2.2. This PR does not republish either artifact. certifi 2026.10.23 also drops unaffected eMudhra roots, so this pin stays on the advisory version.

Test Plan

  • Dependency pin and lockfile only. No application code change.

Rollback Plan

Revert this PR. No schema or data migration.

Made with Cursor


Note

Low Risk
Dependency pin and lockfile update with a regression test; no application logic changes beyond TLS trust roots for local CLI installs.

Reviewed by Cursor Bugbot for commit 9423be3. Configure here.

DEFVULN-51432

Co-authored-by: Cursor <cursoragent@cursor.com>
@adgupta21
adgupta21 requested review from a team as code owners November 3, 2026 19:40
The pyproject pin and poetry.lock are the fix. The bundle assertion only locks a version string.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tohp-human-presence

tohp-human-presence Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Test of Human Presence

A human approval is required for the current head commit.

Approved by adgupta21.

Commit: 8eaca7b

Pushing another commit replaces this comment and requires approval for the new head SHA.

@adgupta21
adgupta21 merged commit d971ff3 into main Nov 4, 2026
4 checks passed
@adgupta21
adgupta21 deleted the DEFVULN-51432 branch November 4, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants