Reddit hangs fix

[Ditiae]

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

• a bug fix (Fix #...)
• a new Ripper
• a refactoring
• a style change/fix
• a new feature

Description

Please add details about your change here.
Made all possible post titles valid for folder/file paths in Windows.
fixes #1536
fixes #1477
fixes #1399
fixes #1357
fixes #1515
fixes #1518

Testing

Required verification:

• I've verified that there are no regressions in mvn test (there are no new failures or errors).
• I've verified that this change works as intended.
  • Downloads all relevant content.
  • Downloads content from multiple pages (as necessary or appropriate).
  • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
• I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

• I've added a unit test to cover my change.

[Ditiae]

Do not merge. Not finished.

[madhatr]

#1541 Likely related

[cyian-1756]

@Wea1thRS any update on this?

[Ditiae]

@cyian-1756 I've been really busy, and likely can't work on this anytime soon. I think I've gieven enough information and enough of a poc that someone should be able to polish it up and push it. I just can't right now. Sorry. Feel free to do what you'd like with what I have done so far though.

Edit: To put it simply, the entire issue is really only just windows not allowing some of the characters reddit is giving. If you add a check to remove/change those characters, all issues should be fixed. As not all titles are getting sanitized correctly.

Sorry to leave this pr half-finished, expected to have time to work on it, this wasn't my intention when starting it.

[perpetualogic]

I was running into this issue in Linux, and applying your changes locally seemed to fix it. I'll keep testing and switch over to Windows for some testing too and see if I can replicate.

[WouterV85]

Your fix doesn't fix it when the title has a '/' in it's name, because new Fil converts the '/' to ''.
Example

The title (or others) in handleURL in RedditRipper needs a sanitizeSaveAs as well.