refactor(toolchain): add shared tsconfig.base.json; extend it everywhere (RIG-3115) - #831
Merged
Merged
Conversation
|
Compass engineering docs preview: https://compass-native-rig-3115-tsco.compass-eng-docs.pages.dev Deployed from |
…ere (RIG-3115) The compass tree had no shared tsconfig base — every project shipped a standalone copy, the tool ones byte-identical. This adds a root `tsconfig.base.json` (matching how biome uses `extends: //` and bun uses one lock + catalog) and points every non-fork, non-astro project at it, leaving only genuine per-project deltas (apps/ui's DOM/Solid libs, per-project `types`/`include`, the tools' module-handling flags: `moduleDetection`, `allowJs`, `allowImportingTsExtensions`). eng-docs (Astro toolchain) and forks/ keep their own bases and are untouched. Strict-flag unification: `noFallthroughCasesInSwitch` and `noImplicitOverride` fold into the base — the full `:typecheck` gate stays green repo-wide with them applied everywhere. `noUncheckedIndexedAccess` is deferred: lifting it repo-wide surfaces 385 pre-existing latent type errors in the leaner projects (packages/compass-agent 165, apps/ui 219, tools/toolchain/devenv-cli 1), all TS18048/TS2532/TS2345/TS2322 'possibly undefined' at index accesses. It remains a per-leaf delta on the 14 tool configs that already had it; fixing the product-code errors is out of scope for this structural PR and is left for a follow-up. Spec-impact: none. Refs RIG-3115 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-native/rig-3115-tsconfig-base
branch
from
September 1, 2026 03:30
ba0728f to
835b042
Compare
rigel-mintaka
marked this pull request as ready for review
September 1, 2026 03:30
mattwilkinsonn
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compass tree had no shared tsconfig base — every project shipped a standalone copy, the tool ones byte-identical. This adds a root
tsconfig.base.json(matching how biome usesextends: //and bun uses one lock + catalog) and points every non-fork, non-astro project at it, leaving only genuine per-project deltas (apps/ui's DOM/Solid libs, per-projecttypes/include, the tools' module-handling flags:moduleDetection,allowJs,allowImportingTsExtensions).eng-docs (Astro toolchain) and forks/ keep their own bases and are untouched.
Strict-flag unification:
noFallthroughCasesInSwitchandnoImplicitOverridefold into the base — the full:typecheckgate stays green repo-wide with them applied everywhere.noUncheckedIndexedAccessis deferred: lifting it repo-wide surfaces 385 pre-existing latent type errors in the leaner projects (packages/compass-agent 165, apps/ui 219, tools/toolchain/devenv-cli 1), all TS18048/TS2532/TS2345/TS2322 'possibly undefined' at index accesses. It remains a per-leaf delta on the 14 tool configs that already had it; fixing the product-code errors is out of scope for this structural PR and is left for a follow-up.Spec-impact: none.
Refs RIG-3115
Co-authored-by: Matt Wilkinson matt@rigel.build