Skip to content

RU-T50 Fixes#249

Merged
ucswift merged 2 commits into
masterfrom
develop
Jun 18, 2026
Merged

RU-T50 Fixes#249
ucswift merged 2 commits into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an issue preventing Live Activities from functioning properly in the main iOS application. Users can now reliably manage Live Activities through the native activity system.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ucswift, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 47 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d147918b-dc1a-4a25-af3f-2fb415915a50

📥 Commits

Reviewing files that changed from the base of the PR and between 5ce249f and 29edbb7.

📒 Files selected for processing (1)
  • plugins/withCheckInLiveActivity.js
📝 Walkthrough

Walkthrough

The Expo config plugin withCheckInLiveActivity.js is updated to write CheckInTimerAttributes.swift into the main iOS app target directory during the dangerous-mod phase, and to include that file path in the Xcode project host target source files during the wiring phase.

Changes

App Target CheckInTimerAttributes Wiring

Layer / File(s) Summary
Generate and register CheckInTimerAttributes.swift in host target
plugins/withCheckInLiveActivity.js
During the dangerous-mod step, CheckInTimerAttributes.swift is written to ios/<appName>/. During Xcode wiring, ${appName}/CheckInTimerAttributes.swift is added to the host target's compiled source file list alongside the activity manager and ObjC bridge.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Resgrid/Unit#237: Modifies the same Xcode project patching and target-wiring logic in plugins/withCheckInLiveActivity.js, overlapping with the host target configuration flow changed here.

Suggested reviewers

  • github-actions

🐇 A swift file hops into the app,
No longer lost in widget's gap.
The host now sees the attributes bright,
ActivityKit starts feeling right.
Two small lines, a big leap — hooray! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RU-T50 Fixes' is a vague reference to a ticket identifier that does not clearly describe what the changeset actually does. It lacks specificity about the actual code changes. Use a descriptive title that explains the actual change, such as 'Ensure CheckInTimerAttributes.swift compiles in main iOS app target' or 'Add ActivityKit support to main app target for Live Activities'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/withCheckInLiveActivity.js`:
- Around line 530-533: The host-target source wiring that adds
${appName}/CheckInTimerAttributes.swift to the host target is unreachable for
existing widget targets due to an early return at lines 387-389 that exits
before reaching line 533. Move the host-target source wiring logic (including
the ${appName}/CheckInTimerAttributes.swift entry) outside of the early-return
block, or restructure the conditional logic to only gate the widget-target
creation logic while allowing the host-target bridging and source file additions
to execute regardless of whether the target already exists or is newly created.
This ensures the migration applies idempotently for both new and existing
projects.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be2f6841-19a3-41c7-8e6e-53b635f0df18

📥 Commits

Reviewing files that changed from the base of the PR and between 71c27b4 and 5ce249f.

📒 Files selected for processing (1)
  • plugins/withCheckInLiveActivity.js

Comment thread plugins/withCheckInLiveActivity.js Outdated
@ucswift

ucswift commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

Approve

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit ed1af07 into master Jun 18, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant