RU-T50 More build fix

[ucswift]

Summary by CodeRabbit

• Refactor

  • Updated the plugin's build configuration detection mechanism to use a marker-based approach for improved reliability.

• Documentation

  • Enhanced comments in the build hook to provide clearer coverage information regarding framework compatibility handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e0bb8a51-1a25-4711-92ca-16c711d7fb0f

📥 Commits

Reviewing files that changed from the base of the PR and between 7c8719d and 89f558c.

📒 Files selected for processing (1)

• plugins/withWebRTCFrameworkFix.js

---

📝 Walkthrough

Walkthrough

The Podfile post_install injection guard in withWebRTCFrameworkFix.js is changed from checking for CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES to checking for a unique sentinel comment # @withWebRTCFrameworkFix:post-install. The injected hook's comment block is updated to describe the all-pods scope of the Xcode 26+ non-modular include fix.

Changes

WebRTC Plugin Podfile Hook Guard

Layer / File(s)	Summary
Podfile hook idempotency guard and comment update plugins/withWebRTCFrameworkFix.js	Replaces the idempotency check from contents.includes('CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES') to a plugin-unique sentinel comment # @withWebRTCFrameworkFix:post-install, and updates the injected hook's comment block to reflect all-pods scope language while preserving the underlying build setting behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Resgrid/Unit#241: Modifies the same plugins/withWebRTCFrameworkFix.js Podfile post-install injection and idempotency logic.
• Resgrid/Unit#242: Directly overlaps on the same function's injected hook comments and all-pods scope language in withWebRTCFrameworkFix.js.
• Resgrid/Unit#243: Modifies the same Podfile patching logic and idempotency behavior in withWebRTCFrameworkFix.js.

Suggested reviewers

• github-actions

Poem

🐇 A sentinel stands where a string used to be,
A comment so unique, just for WebRTC!
"All pods, take heed!" the Ruby hook cries,
No modular mischief beneath Xcode skies.
The bunny hops on — the build error dies! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'RU-T50 More build fix' is vague and does not clearly describe the specific change made to the withWebRTCFrameworkFix plugin.	Use a more descriptive title that explains the actual change, such as 'Replace idempotency check in withWebRTCFrameworkFix plugin' or 'Update WebRTC framework fix with unique idempotency marker'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ucswift]

Approve

[github-actions]

This PR is approved.