fix: honor poke reply toggle#124
Open
Rat0323 wants to merge 2 commits into
Open
Conversation
Author
|
I added a follow-up commit ( The previous test checked for the guard as text. It now parses target_id == bot_id and self.cfg.poke_reply_enabledValidation run locally: python -m unittest tests.test_config_contract
python -m py_compile main.py tests\test_config_contract.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poke_reply_enabledsetting before scheduling poke replies.CHANGELOG.mdunderUnreleased.Problem
The plugin exposes
poke_reply_enabledin both_conf_schema.jsonandPluginConfig, and the schema says disabling it should stop poke interactions. However, theon_message_listenerpoke branch always schedules_poke_reply_async()whenever the bot is poked:As a result, setting
poke_reply_enabledtofalsedoes not actually prevent the bot from poking back or sending a random complaint text.Fix
The handler now checks the toggle before scheduling the poke reply task:
The event is still stopped after handling a
Pokecomponent, preserving the existing event propagation behavior.Tests
python -m unittest tests.test_config_contractpython -m py_compile main.py tests\test_config_contract.pyNote:
ruff check main.py tests/test_config_contract.pycurrently reports many pre-existing lint issues in unchanged code, so it is not clean on this branch.