Skip to content

End pageController.js on a cloneable value for Firefox #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InventivetalentDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

End pageController.js on a cloneable value for Firefox #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pageController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,3 +533,8 @@ function onlyRunOnce(f, t) {
console.info("Joining session #" + remote_slide.session + " as host (" + remote_slide.injector + ")");
status("orange", "question", "");
socket.connect({session: remote_slide.session, role: "host", injector: remote_slide.injector});
// The extension injects this file with scripting.executeScript(), which hands
// the script's last value back to it. Firefox rejects the whole call when that
// value cannot be structured-cloned - as the socket connect() returns cannot -
// and the extension would never go on to load the overlay. So end on a plain value.
undefined;