Skip to content

Commit 944e920

Browse files
committed
address @mgates' suggestion: "I tend to reset pointers to NULL after freeing them, to avoid any possible confusion."
1 parent 6c4efb0 commit 944e920

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

LAPACKE/src/lapacke_cgesvdq_work.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,11 @@ lapack_int API_SUFFIX(LAPACKE_cgesvdq_work)( int matrix_layout, char joba, char
172172
}
173173

174174
/* Release memory and exit */
175-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( v_t );
175+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( v_t ); v_t = NULL; }
176176
exit_level_2:
177-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( u_t );
177+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( u_t ); u_t = NULL; }
178178
exit_level_1:
179-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( a_t );
179+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( a_t ); a_t = NULL; }
180180
exit_level_0:
181181
if( info == LAPACK_TRANSPOSE_MEMORY_ERROR ) {
182182
API_SUFFIX(LAPACKE_xerbla)( "LAPACKE_cgesvdq_work", info );

LAPACKE/src/lapacke_dgesvdq_work.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,11 @@ lapack_int API_SUFFIX(LAPACKE_dgesvdq_work)( int matrix_layout, char joba, char
174174
}
175175

176176
/* Release memory and exit */
177-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( v_t );
177+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( v_t ); v_t = NULL; }
178178
exit_level_2:
179-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( u_t );
179+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( u_t ); u_t = NULL; }
180180
exit_level_1:
181-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( a_t );
181+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( a_t ); a_t = NULL; }
182182
exit_level_0:
183183
if( info == LAPACK_TRANSPOSE_MEMORY_ERROR ) {
184184
API_SUFFIX(LAPACKE_xerbla)( "LAPACKE_dgesvdq_work", info );

LAPACKE/src/lapacke_sgesvdq_work.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,11 @@ lapack_int API_SUFFIX(LAPACKE_sgesvdq_work)( int matrix_layout, char joba, char
174174
}
175175

176176
/* Release memory and exit */
177-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( v_t );
177+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( v_t ); v_t = NULL; }
178178
exit_level_2:
179-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( u_t );
179+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( u_t ); u_t = NULL; }
180180
exit_level_1:
181-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( a_t );
181+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( a_t ); a_t = NULL; }
182182
exit_level_0:
183183
if( info == LAPACK_TRANSPOSE_MEMORY_ERROR ) {
184184
API_SUFFIX(LAPACKE_xerbla)( "LAPACKE_sgesvdq_work", info );

LAPACKE/src/lapacke_zgesvdq_work.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,11 @@ lapack_int API_SUFFIX(LAPACKE_zgesvdq_work)( int matrix_layout, char joba, char
172172
}
173173

174174
/* Release memory and exit */
175-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( v_t );
175+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( v_t ); v_t = NULL; }
176176
exit_level_2:
177-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( u_t );
177+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( u_t ); u_t = NULL; }
178178
exit_level_1:
179-
if ( ( m > 0 ) && ( n > 0 ) ) LAPACKE_free( a_t );
179+
if ( ( m > 0 ) && ( n > 0 ) ) { LAPACKE_free( a_t ); a_t = NULL; }
180180
exit_level_0:
181181
if( info == LAPACK_TRANSPOSE_MEMORY_ERROR ) {
182182
API_SUFFIX(LAPACKE_xerbla)( "LAPACKE_zgesvdq_work", info );

0 commit comments

Comments
 (0)