address @mgates' suggestion: "A comment that joba == e is using V as workspace would be helpful. (Per later comment when transposing results.)"

langou · langou · commit 6c4efb030720 · 2026-03-31T09:07:39.000-06:00
diff --git a/LAPACKE/src/lapacke_cgesvdq_work.c b/LAPACKE/src/lapacke_cgesvdq_work.c
@@ -74,6 +74,7 @@ lapack_int API_SUFFIX(LAPACKE_cgesvdq_work)( int matrix_layout, char joba, char
            ncols_u = 1;
         }
 
+        /* in the case joba == 'e', v_t is used as a workspace */
         if( API_SUFFIX(LAPACKE_lsame)( jobv, 'a' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'v' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'r' ) ||
diff --git a/LAPACKE/src/lapacke_dgesvdq_work.c b/LAPACKE/src/lapacke_dgesvdq_work.c
@@ -74,6 +74,7 @@ lapack_int API_SUFFIX(LAPACKE_dgesvdq_work)( int matrix_layout, char joba, char
            ncols_u = 1;
         }
 
+        /* in the case joba == 'e', v_t is used as a workspace */
         if( API_SUFFIX(LAPACKE_lsame)( jobv, 'a' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'v' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'r' ) ||
diff --git a/LAPACKE/src/lapacke_sgesvdq_work.c b/LAPACKE/src/lapacke_sgesvdq_work.c
@@ -74,6 +74,7 @@ lapack_int API_SUFFIX(LAPACKE_sgesvdq_work)( int matrix_layout, char joba, char
            ncols_u = 1;
         }
 
+        /* in the case joba == 'e', v_t is used as a workspace */
         if( API_SUFFIX(LAPACKE_lsame)( jobv, 'a' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'v' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'r' ) ||
diff --git a/LAPACKE/src/lapacke_zgesvdq_work.c b/LAPACKE/src/lapacke_zgesvdq_work.c
@@ -74,6 +74,7 @@ lapack_int API_SUFFIX(LAPACKE_zgesvdq_work)( int matrix_layout, char joba, char
            ncols_u = 1;
         }
 
+        /* in the case joba == 'e', v_t is used as a workspace */
         if( API_SUFFIX(LAPACKE_lsame)( jobv, 'a' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'v' ) ||
                 API_SUFFIX(LAPACKE_lsame)( jobv, 'r' ) ||

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ lapack_int API_SUFFIX(LAPACKE_cgesvdq_work)( int matrix_layout, char joba, char`
`74`	`74`	`ncols_u = 1;`
`75`	`75`	`}`
`76`	`76`
	`77`	`+ /* in the case joba == 'e', v_t is used as a workspace */`
`77`	`78`	`if( API_SUFFIX(LAPACKE_lsame)( jobv, 'a' ) \|\|`
`78`	`79`	`API_SUFFIX(LAPACKE_lsame)( jobv, 'v' ) \|\|`
`79`	`80`	`API_SUFFIX(LAPACKE_lsame)( jobv, 'r' ) \|\|`