Repository navigation
Update module github.com/project-kessel/kessel-sdk-go to v1.13.1 - #2378
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis dependency-only update moves the Kessel SDK to v1.13.1 and refreshes module metadata; the release includes regenerated protobufs, OAuth2 rejection on insecure channels, and repository governance/documentation updates. Review compatibility with existing Kessel client usage and the intentional Go version change before relying on automerge. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Due to Go's usage of Minimal Version Selection (MVS), these packages have been updated to the minimum version available, so will still abide by Details:
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="go.mod" line_range="24" />
<code_context>
github.com/lib/pq v1.12.3
github.com/pkg/errors v0.9.1
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
- github.com/project-kessel/kessel-sdk-go v1.13.0
+ github.com/project-kessel/kessel-sdk-go v1.13.1
github.com/prometheus/client_golang v1.25.0
</code_context>
<issue_to_address>
**Kessel checks return server errors**
When `KESSEL_AUTH_ENABLED` and `KESSEL_INSECURE` are both true, `setupClient` combines OAuth2 credentials with an insecure channel, so SDK v1.13.1's `Build()` returns an error; `hasPermissionKessel` returns HTTP 500 for Kessel-protected requests, and `TestSetupClient`'s success assertion fails.
Use a secure channel whenever OAuth2 authentication is enabled.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: go.mod:24
| github.com/lib/pq v1.12.3 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 | ||
| github.com/project-kessel/kessel-sdk-go v1.13.0 |
There was a problem hiding this comment.
🔴 Critical · Kessel checks return server errors
When KESSEL_AUTH_ENABLED and KESSEL_INSECURE are both true, setupClient combines OAuth2 credentials with an insecure channel, so SDK v1.13.1's Build() returns an error; hasPermissionKessel returns HTTP 500 for Kessel-protected requests, and TestSetupClient's success assertion fails.
Use a secure channel whenever OAuth2 authentication is enabled.
Prompt for AI agents
In `go.mod` at line 24:
**Kessel checks return server errors**
When `KESSEL_AUTH_ENABLED` and `KESSEL_INSECURE` are both true, `setupClient` combines OAuth2 credentials with an insecure channel, so SDK v1.13.1's `Build()` returns an error; `hasPermissionKessel` returns HTTP 500 for Kessel-protected requests, and `TestSetupClient`'s success assertion fails.
Use a secure channel whenever OAuth2 authentication is enabled.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2378 +/- ##
=======================================
Coverage 60.14% 60.14%
=======================================
Files 158 158
Lines 10161 10161
=======================================
Hits 6111 6111
Misses 3424 3424
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This PR contains the following updates:
v1.13.0→v1.13.1Release Notes
project-kessel/kessel-sdk-go (github.com/project-kessel/kessel-sdk-go)
v1.13.1Compare Source
What's Changed
Full Changelog: project-kessel/kessel-sdk-go@v1.13.0...v1.13.1
Configuration
📅 Schedule: (in timezone Europe/Prague)
* 3-10 * * 1)🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.
Summary by Sourcery
Update the Go module dependencies to consume the latest Kessel SDK patch release and Go toolchain version.
Enhancements:
Build: