Repository navigation
refactor(frontend): untangle the workspace store, services and trial display - #152
Merged
Merged
Conversation
This was referenced Nov 9, 2026
safina57
force-pushed
the
refactor/frontend-untangle
branch
from
November 9, 2026 13:38
4d23dd2 to
f0a084a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untangles the frontend so a typical change lands in one place.
Structure
HomePageand the tour.hooks/useWorkspace.ts.HomePageonly picksDesktopLayoutorMobileLayout;MobileLayoutgoes from 13 props to 3.trialQuery()replaces['trial', ref]from 7 places and thefetchTrialprop that existed only for tests.services/api.tsreplaces the fetch, error and camelCase code copied into six services.constants/trialStatus.ts(key order is display priority),StatusDotandStatusLabel, plus title, place and site-key helpers inlib/trial.BrandTitle(header, mobile menu, consent),LanguageOptions(gate, picker, mobile menu), the PDF owns its English copy,MapPanelplaces its own overlays (compact,topInset).lib/motion).TrialMarker,extractTrialRefs, unused Turnstile fields, Ontario geojson, 8 unused locale keys).Fixes
useChatwrote a field renamed in feat: wire the agent to the full CTC corpus #102).Visible changes
The new locale strings (
chat.showOnMap,chat.definition,feedback.removeNct,feedback.failed) need a native-speaker check.