Dev.ej/ci playwright#556
Merged
Merged
Conversation
|
Review changes with Changed Files
|
Contributor
|
This allows us to let the servers start while playwright browsers are downloading, which means we don't need to sleep 50s just waiting for the servers to start.
CI hung on installing browsers. The fix is to use playwright>=1.60, as documented at microsoft/playwright#40998
joanise
force-pushed
the
dev.ej/ci-playwright
branch
from
af39887 to
69061bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Fix CI's hanging problem when installing Playwright browsers
Fixes?
microsoft/playwright#40998
Feedback sought?
sanity check
Priority?
high, CI is broken until this is merged.
How to test?
See that CI passes
Confidence?
high
Version change?
no