Skip to content

4.x: Isolate Maybe takeUntil race tests #8319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akarnokd merged 1 commit into from
Oct 11, 2026
Merged

4.x: Isolate Maybe takeUntil race tests #8319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTakeUntilIsolatedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/*
* Copyright (c) 2016-present, RxJava Contributors.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in
* compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
* the License for the specific language governing permissions and limitations under the License.
*/

package io.reactivex.rxjava4.internal.operators.maybe;

import java.util.List;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.parallel.Isolated;

import io.reactivex.rxjava4.core.RxJavaTest;
import io.reactivex.rxjava4.exceptions.TestException;
import io.reactivex.rxjava4.observers.TestObserver;
import io.reactivex.rxjava4.plugins.RxJavaPlugins;
import io.reactivex.rxjava4.processors.PublishProcessor;
import io.reactivex.rxjava4.testsupport.TestHelper;

@Isolated
public class MaybeTakeUntilIsolatedTest extends RxJavaTest {

@Test
public void onErrorRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2.singleElement()).test();

final TestException ex1 = new TestException();
final TestException ex2 = new TestException();

List<Throwable> errors = TestHelper.trackPluginErrors();
try {

Runnable r1 = () -> pp1.onError(ex1);
Runnable r2 = () -> pp2.onError(ex2);

TestHelper.race(r1, r2);

to.assertFailure(TestException.class);

if (!errors.isEmpty()) {
TestHelper.assertUndeliverable(errors, 0, TestException.class);
}

} finally {
RxJavaPlugins.reset();
}

}
}

@Test
public void onCompleteRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2.singleElement()).test();

Runnable r1 = pp1::onComplete;
Runnable r2 = pp2::onComplete;

TestHelper.race(r1, r2);

to.assertResult();
}
}
}
79 changes: 79 additions & 0 deletions ...va/io/reactivex/rxjava4/internal/operators/maybe/MaybeTakeUntilPublisherIsolatedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/*
* Copyright (c) 2016-present, RxJava Contributors.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in
* compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
* the License for the specific language governing permissions and limitations under the License.
*/

package io.reactivex.rxjava4.internal.operators.maybe;

import java.util.List;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.parallel.Isolated;

import io.reactivex.rxjava4.core.RxJavaTest;
import io.reactivex.rxjava4.exceptions.TestException;
import io.reactivex.rxjava4.observers.TestObserver;
import io.reactivex.rxjava4.plugins.RxJavaPlugins;
import io.reactivex.rxjava4.processors.PublishProcessor;
import io.reactivex.rxjava4.testsupport.TestHelper;

@Isolated
public class MaybeTakeUntilPublisherIsolatedTest extends RxJavaTest {

@Test
public void onErrorRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2).test();

final TestException ex1 = new TestException();
final TestException ex2 = new TestException();

List<Throwable> errors = TestHelper.trackPluginErrors();
try {

Runnable r1 = () -> pp1.onError(ex1);
Runnable r2 = () -> pp2.onError(ex2);

TestHelper.race(r1, r2);

to.assertFailure(TestException.class);

if (!errors.isEmpty()) {
TestHelper.assertUndeliverable(errors, 0, TestException.class);
}

} finally {
RxJavaPlugins.reset();
}

}
}

@Test
public void onCompleteRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2).test();

Runnable r1 = pp1::onComplete;
Runnable r2 = pp2::onComplete;

TestHelper.race(r1, r2);

to.assertResult();
}
}
}
49 changes: 0 additions & 49 deletions src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTakeUntilPublisherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,55 +110,6 @@ public void otherCompletes() {
to.assertResult();
}

@Test
public void onErrorRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2).test();

final TestException ex1 = new TestException();
final TestException ex2 = new TestException();

List<Throwable> errors = TestHelper.trackPluginErrors();
try {

Runnable r1 = () -> pp1.onError(ex1);
Runnable r2 = () -> pp2.onError(ex2);

TestHelper.race(r1, r2);

to.assertFailure(TestException.class);

if (!errors.isEmpty()) {
TestHelper.assertUndeliverable(errors, 0, TestException.class);
}

} finally {
RxJavaPlugins.reset();
}

}
}

@Test
public void onCompleteRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2).test();

Runnable r1 = pp1::onComplete;
Runnable r2 = pp2::onComplete;

TestHelper.race(r1, r2);

to.assertResult();
}
}

@Test
public void otherSignalsAndCompletes() {
List<Throwable> errors = TestHelper.trackPluginErrors();
Expand Down
52 changes: 0 additions & 52 deletions src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTakeUntilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,11 @@

import static org.junit.jupiter.api.Assertions.*;

import java.util.List;

import org.junit.jupiter.api.Test;

import io.reactivex.rxjava4.core.*;
import io.reactivex.rxjava4.exceptions.TestException;
import io.reactivex.rxjava4.observers.TestObserver;
import io.reactivex.rxjava4.plugins.RxJavaPlugins;
import io.reactivex.rxjava4.processors.PublishProcessor;
import io.reactivex.rxjava4.subjects.MaybeSubject;
import io.reactivex.rxjava4.testsupport.TestHelper;
Expand Down Expand Up @@ -139,55 +136,6 @@ public void otherCompletes() {
to.assertResult();
}

@Test
public void onErrorRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2.singleElement()).test();

final TestException ex1 = new TestException();
final TestException ex2 = new TestException();

List<Throwable> errors = TestHelper.trackPluginErrors();
try {

Runnable r1 = () -> pp1.onError(ex1);
Runnable r2 = () -> pp2.onError(ex2);

TestHelper.race(r1, r2);

to.assertFailure(TestException.class);

if (!errors.isEmpty()) {
TestHelper.assertUndeliverable(errors, 0, TestException.class);
}

} finally {
RxJavaPlugins.reset();
}

}
}

@Test
public void onCompleteRace() {
for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) {
final PublishProcessor<Integer> pp1 = PublishProcessor.create();
final PublishProcessor<Integer> pp2 = PublishProcessor.create();

TestObserver<Integer> to = pp1.singleElement().takeUntil(pp2.singleElement()).test();

Runnable r1 = pp1::onComplete;
Runnable r2 = pp2::onComplete;

TestHelper.race(r1, r2);

to.assertResult();
}
}

@Test
public void untilMaybeMainSuccess() {
MaybeSubject<Integer> main = MaybeSubject.create();
Expand Down
Loading