Repository navigation
Fix sync race condition causing loss of local feed item state. - #691
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a race condition where changing feed filters while a sync was in flight could wipe
saved_for_later(andpodcast_start_position) on persisted items.Sync used to read existing items for the currently selected sources, copy over the local state, then rewrite each row with
INSERT OR REPLACE. If the selection changed after the request went out, items from sources that were no longer selected weren't in that read, so they were rewritten withsaved_for_later = false.Changes:
upsertFeedItemnow updates only the columns that come from the server, thenINSERT OR IGNOREs new rows. Sync no longer touches local-only columns, so there's no pre-read and nothing to carry over. This replacesINSERT OR REPLACE, which deleted and re-inserted rows.insertFeedItemfor seeding test data.