Skip to content

Declare variables at point of use in assign.c#7303

Merged
ben-schwen merged 10 commits into
masterfrom
dataCodeIntegration3
Jun 1, 2026
Merged

Declare variables at point of use in assign.c#7303
ben-schwen merged 10 commits into
masterfrom
dataCodeIntegration3

Conversation

@badasahog
Copy link
Copy Markdown
Contributor

Data desegregation + minor formatting improvements + constness improvements

progress towards #6971

As an aside, I've been awaiting review for other PRs, #7248, #7247, #7244, #7238

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 10, 2025

  • HEAD=dataCodeIntegration3 much faster for as.data.table.array improved in #7019
    Comparison Plot

Generated via commit 153815d

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 26 seconds
Installing different package versions 11 minutes and 55 seconds
Running and plotting the test cases 5 minutes and 22 seconds

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (479ff3a) to head (153815d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7303   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          87       87           
  Lines       17127    17128    +1     
=======================================
+ Hits        16931    16932    +1     
  Misses        196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rikivillalba
Copy link
Copy Markdown
Contributor

Might conflict with 2db2a90 #7343

Comment thread src/assign.c Outdated
Comment thread src/assign.c Outdated
@ben-schwen ben-schwen changed the title Data desegregation Declare variables at point of use in assign.c Jun 1, 2026
@ben-schwen ben-schwen merged commit 82380b2 into master Jun 1, 2026
15 checks passed
@ben-schwen ben-schwen deleted the dataCodeIntegration3 branch June 1, 2026 07:30
@ben-schwen
Copy link
Copy Markdown
Member

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants