Add CI workflow for RPL pattern checks and remove build script - #124
Merged
Conversation
- Introduced a new GitHub Actions workflow (`check-patterns.yml`) to validate RPL patterns, ensuring they are correctly listed and ordered in `patterns.rs`, and checking UI stderr hygiene. - Removed the obsolete `build.rs` script, which was previously responsible for generating `patterns.rs`. - Updated `patterns.rs` to reflect manual maintenance requirements for pattern entries, emphasizing the need for consistency with the filesystem structure.
- Added `cassandra-cpp-sys` version 1.1.1 to `Cargo.toml` and `Cargo.lock`. - Removed the unused pattern file `CVE-2020-35886.rpl` and associated `.stderr` files from the tests. - Updated test files to ensure they compile and run correctly without the removed patterns.
- Changed `cassandra-cpp-sys` from dependencies to dev-dependencies in `Cargo.toml` for Windows and macOS targets. - Added a step in the GitHub Actions workflow to install the Cassandra C++ driver on Linux, ensuring the necessary build tools and libraries are available for the CI environment. - Updated a test file to target Linux instead of Windows, aligning with the new dependency configuration.
…ependency to Linux only - Modified the `Cargo.toml` to limit the `cassandra-cpp-sys` dev-dependency to Linux targets. - Updated `compile-test.rs` to reflect the change, ensuring compatibility with the new dependency configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-patterns.yml) to validate RPL patterns, ensuring they are correctly listed and ordered inpatterns.rs, and checking UI stderr hygiene.build.rsscript, which was previously responsible for generatingpatterns.rs.patterns.rsto reflect manual maintenance requirements for pattern entries, emphasizing the need for consistency with the filesystem structure.