Skip to content

ci: skip rocdecode_video_decode_caps on stable ROCm 10.1 gfx1151 - #560

Merged
zichguan-amd merged 1 commit into
amd-stagingfrom
zichguan/ci-skip-rocdecode-caps-stable-gfx1151
Oct 27, 2026
Merged

zichguan-amd merged 1 commit into
amd-stagingfrom
zichguan/ci-skip-rocdecode-caps-stable-gfx1151

Conversation

@zichguan-amd

Copy link
Copy Markdown
Collaborator

Motivation

rocdecode_video_decode_caps (added in #550) has failed every nightly since 2026-10-23 on Ubuntu 24.04 (ROCm 10.1) - gfx1151 - preinstalled. It passes on stable gfx1100 and on all nightly gfx1151 jobs.

AVC/H.264   YUV 4:2:0       8-bit          2        64x64           4096x4096           NV12
[0, Critical] vaapi_videodecoder.cpp:1015: ... CheckDecCapForCodecType(): VAAPI failure: vaCreateConfig(...)
Error: rocDecGetDecoderCaps failed: ROCDEC_RUNTIME_ERROR

The ROCm 10.1 rocDecode maps unmapped codec/bit-depth combinations (e.g. HEVC 12-bit) to VAProfileNone and then calls vaCreateConfig on it. Mesa only advertises VAProfileNone on GPUs with a VPE block. gfx1151 has one and gfx1100 doesn't, so on gfx1151 rocDecGetDecoderCaps returns ROCDEC_RUNTIME_ERROR instead of reporting the combination as unsupported. This was fixed upstream in ROCm/rocm-systems#11724, which is not in ROCm 10.1. The nightly rocDecode has the fix, which is why the nightly gfx1151 jobs pass.

Technical Details

  • .github/build_tools/skip_manifest.py: add a test-only skip for rocdecode_video_decode_caps (ctest key plus make test path), scoped to channels: ["stable"] and targets: ["gfx1151"].
  • The example is still built everywhere and still tested on stable gfx1100 and every nightly job.
  • The entry can be removed once the stable image moves to a ROCm release that includes fix(rocDecocde): Fix two issues in decoder capability check. rocm-systems#11724.

Test Plan

  • Ran generate_skip_tests.py for stable/gfx1151/preinstalled, stable/gfx1100/preinstalled, nightly/gfx1151/tarball-multi-arch and nightly/gfx1151/whl-multi-arch.
  • On gfx1100, in ghcr.io/rocm/rocm-examples-ubuntu-24.04-rocm:10.1:
    • configured Libraries/rocDecode with CMake and ran ctest -R video_decode_caps with and without the generated skip_tests.txt;
    • ran make -n -C Libraries/rocDecode test with the generated SKIP_FROM_TEST.

Test Result

  • The entry appears only in the stable gfx1151 output (skip_tests.txt and SKIP_FROM_TEST).
  • ctest finds no matching test with the exclude file. Without it, the test passes.
  • make test drops video_decode_caps and keeps the other 10 rocDecode examples.
  • black --check passes on the changed file.
  • I didn't run the gfx1151 job itself locally because no gfx1151 is available here.

Added/Updated documentation?

  • Yes
  • No, does not apply to this PR.

Included Visual Studio files?

  • Yes
  • No, does not apply to this PR.

Submission Checklist

🤖 Generated with Claude Code

The ROCm 10.1 rocDecode maps unmapped codec/bit-depth combinations (e.g.
HEVC 12-bit) to VAProfileNone and calls vaCreateConfig on it. Mesa only
advertises VAProfileNone on GPUs with a VPE block (gfx1151, not gfx1100),
so on gfx1151 rocDecGetDecoderCaps returns ROCDEC_RUNTIME_ERROR instead of
reporting the combination as unsupported, and the example exits 1. Fixed
upstream in ROCm/rocm-systems#11724, which is not in ROCm 10.1.

Skip the test only on the stable channel for gfx1151.

Co-Authored-By: Claude <noreply@anthropic.com>
@zichguan-amd
zichguan-amd requested a review from a team as a code owner October 26, 2026 20:08
@zichguan-amd
zichguan-amd merged commit 82780af into amd-staging Oct 27, 2026
16 checks passed
@zichguan-amd
zichguan-amd deleted the zichguan/ci-skip-rocdecode-caps-stable-gfx1151 branch October 27, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant