Repository navigation
explicitly link hip::host to fix linking issue on Windows - #559
Merged
Merged
Conversation
…6 conversions on Windows
zichguan-amd
approved these changes
Oct 26, 2026
zichguan-amd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, please fill in the description before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The ROCm 10.2 rocWMMA package requires OpenMP during package discovery. If OpenMP is unavailable, the examples select a header-only fallback that omits HIP’s host runtime dependencies. On Windows, this can leave
__truncsfhf2and__extendhfsf2unresolved because compiler-rt builtins are missing from the link command.Related: ROCM-33266
Technical Details
Link the fallback target to
hip::hostso HIP supplies the required dependencies. Apply this in both the parent rocWMMA project and each sample to cover aggregate and standalone builds.Test Plan
Test Result
Validation:
simple_hgemmlink failure withCMAKE_DISABLE_FIND_PACKAGE_OpenMP=ON.clang_rt.builtins-x86_64.libappears explicitly on the link command and the build succeeds.Added/Updated documentation?
Included Visual Studio files?
Submission Checklist