Skip to content

sm8550: fix input regressions#2921

Merged
loki666 merged 1 commit into
ROCKNIX:nextfrom
bulzipke:rocknix_fix_inputplumber
Jun 23, 2026
Merged

sm8550: fix input regressions#2921
loki666 merged 1 commit into
ROCKNIX:nextfrom
bulzipke:rocknix_fix_inputplumber

Conversation

@bulzipke

@bulzipke bulzipke commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Testing

  • Tested on Thor(SM8550).
  • Verified that the LID sensor (fake suspend) behaves correctly and that duplicate controller detection is resolved.

Additional Context

  • BTN_BACK button remains unrecognized in RetroArch, as there are no available slots in the DualSense mapping.

AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

@loki666

loki666 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

that will move the KEY_HOME event out of the DS5 controller (it will be on gpio-key device), so it will probably have other effects in standalones mappings

I think the issue is as reported there are two DS5 devices, probably because InputPlumber is creating a second device when it detect the seperate gpio-keys-lid

I'd say the issue is in 02-ayn-controller.yaml‎

@bulzipke

bulzipke commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I see, I didn't take standalones into account.
I'll revert the AYN button mapping back to F24.

@NotYourAveragePaladin

Copy link
Copy Markdown

Bulzipke! It's great to see you! I used your original Digimon VPet emulator along with the evolution trees you put out like 15 years ago. Maybe longer. I used to play with it on my OLD Android phone back wheb I just started Learning about all the cool things Android could do.

@bulzipke bulzipke force-pushed the rocknix_fix_inputplumber branch from 1fd845f to c04112c Compare June 23, 2026 09:00
@bulzipke bulzipke changed the title sm8550: fix input regressions, remap AYN button to KEY_HOME sm8550: fix input regressions Jun 23, 2026
@bulzipke

Copy link
Copy Markdown
Contributor Author

Bulzipke! It's great to see you! I used your original Digimon VPet emulator along with the evolution trees you put out like 15 years ago. Maybe longer. I used to play with it on my OLD Android phone back wheb I just started Learning about all the cool things Android could do.

Hearing that really makes my day. It was such a special time for me, and I’m so glad to hear it brings back fond memories for you as well.

@loki666 loki666 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to figure out what is creating that second DS5 device

Comment thread projects/ROCKNIX/devices/SM8550/linux/dts/qcom/qcs8550-ayn-thor.dts
@NotYourAveragePaladin

Copy link
Copy Markdown

I'd like to add you on Discord, but your name isn't pulling up. Is it something different?

@porschemad911

Copy link
Copy Markdown
Contributor

I'd like to add you on Discord, but your name isn't pulling up. Is it something different?

Please keep PR comments on topic

@bulzipke bulzipke force-pushed the rocknix_fix_inputplumber branch from c04112c to f109976 Compare June 23, 2026 16:13
@bulzipke bulzipke requested a review from loki666 June 23, 2026 16:14
@bulzipke

Copy link
Copy Markdown
Contributor Author

try to figure out what is creating that second DS5 device

Thanks for the kind review.
I've applied the changes as you suggested, and I've confirmed that everything is working correctly.

@bulzipke bulzipke force-pushed the rocknix_fix_inputplumber branch from f109976 to 8446235 Compare June 23, 2026 16:16
@loki666 loki666 added this pull request to the merge queue Jun 23, 2026
Merged via the queue into ROCKNIX:next with commit 520eded Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants