sdl_controllers.txt handling improvement in start_pico8.sh#2882
Open
ae-dschorsaanjo wants to merge 1 commit into
Open
sdl_controllers.txt handling improvement in start_pico8.sh#2882ae-dschorsaanjo wants to merge 1 commit into
ae-dschorsaanjo wants to merge 1 commit into
Conversation
This change would enable users to modify the sdl_controllers.txt file in GAME_DIR for custom keymapping if they wish to without needing to mess with the global configuration. Instead of forcibly rewriting the file, it would only copy it if it does not exist so modifications would be possible, and resetting to default would be a simple matter of manually removing the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change would enable users to modify the sdl_controllers.txt file in GAME_DIR for custom keymapping if they wish to without needing to mess with the global configuration.
Instead of forcibly rewriting the file, it would only copy it if it does not exist so modifications would be possible, and resetting to default would be a simple matter of manually removing the file.
Testing
I implemented the same modification on local installations of other handheld OSs where this file was not write protected.
Additional Context
Should not affect existing behaviour, only enable manual modifications.
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO