Fix touchscreen keyboard abnormal height#2710
Open
EhotPotaskun wants to merge 6 commits into
Open
Conversation
Contributor
|
I need to do some testing, I think on dual screen devices we needed to swap these but I forget why. We might need to make things a little more dynamic. Ill review and follow up on this. |
Contributor
Author
|
If I understand correctly, that fixed line supposed to be executed outside of quirk check, so it's dedicated to single screen devices (as for RG552) and seems like nothing to do with double screen |
Contributor
|
Something is not working right with the keyboard on the 552. It should not look like that. I made some changes recently that adds more keys but I am seeing the same issue. I will do some research today and will also fix a few other things on the rk3399. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Screenshots are from Anbernic RG552
Additional Context
Since vertical mode never used (there's no portrait-mode devices with touchscreen supported by ROCKNIX, am i right?) keyboard's height rolls back to it's defaults
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO