Skip to content

Fix touchscreen keyboard abnormal height#2710

Open
EhotPotaskun wants to merge 6 commits into
ROCKNIX:nextfrom
EhotPotaskun:next
Open

Fix touchscreen keyboard abnormal height#2710
EhotPotaskun wants to merge 6 commits into
ROCKNIX:nextfrom
EhotPotaskun:next

Conversation

@EhotPotaskun

Copy link
Copy Markdown
Contributor

Summary

  • Fix incorrect touchscreen keyboard height, regression in 220e1c8

Testing

Screenshots are from Anbernic RG552

  • Before
20240625_11h39m05s_grim
  • After
20240625_05h55m31s_grim

Additional Context

  • Switches swapped, possibly by mistake. As wvkbd manual says:
-H pixels Height of the keyboard in pixels, for vertical/portrait mode.
-L pixels Height of the keyboard in pixels, for horizontal/landscape mode

Since vertical mode never used (there's no portrait-mode devices with touchscreen supported by ROCKNIX, am i right?) keyboard's height rolls back to it's defaults


AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

@r3claimer

Copy link
Copy Markdown
Contributor

I need to do some testing, I think on dual screen devices we needed to swap these but I forget why. We might need to make things a little more dynamic. Ill review and follow up on this.

@EhotPotaskun

Copy link
Copy Markdown
Contributor Author

If I understand correctly, that fixed line supposed to be executed outside of quirk check, so it's dedicated to single screen devices (as for RG552) and seems like nothing to do with double screen

@r3claimer

Copy link
Copy Markdown
Contributor

Something is not working right with the keyboard on the 552. It should not look like that. I made some changes recently that adds more keys but I am seeing the same issue. I will do some research today and will also fix a few other things on the rk3399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants