Add support for service account when using litellm#295
Merged
Conversation
luis5tb
force-pushed
the
worktree-litellm-sa
branch
2 times, most recently
from
5033377 to
0d11a7a
Compare
luis5tb
changed the title
luis5tb
force-pushed
the
worktree-litellm-sa
branch
2 times, most recently
from
85492da to
6c469a1
Compare
r2dedios
previously approved these changes
Jun 23, 2026
Collaborator
|
Maybe good to add a short description to PR |
Allow using a service account credentials JSON file (GOOGLE_APPLICATION_CREDENTIALS) as a secure alternative to GOOGLE_API_KEY when accessing Vertex AI models, both via direct Gemini and LiteLLM with vertex_ai/* providers. - Add google_application_credentials setting to config - Set GOOGLE_APPLICATION_CREDENTIALS env var in _setup_environment() - Mount GCP SA key in agent deployment (conditional on gcpServiceAccountKey) - Make gcp-sa-secret conditional on key presence (not handler-only) - Fix handler deployment to also be conditional on key presence - Default cloudLocation to global (aligns with Python settings default) - Update docs, .env.example, secrets.yaml.example, and OpenShift README Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The marketplace handler on OpenShift is a standalone service that does not need GCP service account credentials, Gemini API keys, or access to the Google Commerce Procurement API. Remove GOOGLE_APPLICATION_CREDENTIALS, GOOGLE_API_KEY, GOOGLE_CLOUD_PROJECT, and the gcp-sa-key volume mount from the handler deployment template. Also add gcp-sa-secret checksum to the agent deployment and clean up GOOGLE_APPLICATION_CREDENTIALS in tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a file existence check when GOOGLE_APPLICATION_CREDENTIALS is configured. The agent now warns at startup if the specified credentials file path does not exist, making credential misconfiguration easier to diagnose. Changes: - Add pathlib-based file existence check in _setup_environment() - Log warning when credentials file path is invalid - Update test to use tmp_path fixture with actual file - Add new test for missing credentials file warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Restore GOOGLE_CLOUD_PROJECT environment variable to the handler deployment template, sourced from the existing secret with optional: true. This was previously removed but is being added back to keep the handler ready for future Marketplace Procurement API integration if needed. This is a no-op on OpenShift since no Pub/Sub events arrive to trigger the code paths that use this variable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
luis5tb
force-pushed
the
worktree-litellm-sa
branch
from
e844e7a to
c07203b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.