Skip to content

Security: TLS Certificate Validation Disabled #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −4
Open

Security: TLS Certificate Validation Disabled #1702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/helpViewer/cran.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,13 @@ export async function getPackagesFromCran(cranUrl: string): Promise<Package[]> {
for(const site of cranSites){
try{
// fetch html
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'; // seems to fail otherwise?
const res = await fetch(site.url);
const html = await (res).text();

// parse html
packages = site.parseFunction(html, site.url);
} catch(e) {
// These errors are expected, if the repo does not serve a specific URL
} finally {
// make sure to use safe https again
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '1';
}

// break if successfully fetched & parsed
Expand Down
Loading