feat: add cancel_treasury_rotation admin entrypoint #1790
Open
Johnsource-hub wants to merge 1 commit into
Open
feat: add cancel_treasury_rotation admin entrypoint #1790Johnsource-hub wants to merge 1 commit into
Johnsource-hub wants to merge 1 commit into
Conversation
- Implement `cancel_treasury_rotation` to abort pending treasury transitions. - Surface `RotationNotPending` error when no rotation is in progress. - Add negative tests to verify error handling when no rotation is active. - Document threat model: mitigates unauthorized or accidental rotation locks. Closes QuickLendX#1536
|
@Johnsource-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1536. Implements an administrative "circuit breaker" to abort a pending treasury rotation before it is executed.
Threat Model
If this check is missing, a compromised admin account or an accidental misconfiguration could initiate a treasury rotation process that locks the protocol into a pending state. Without this entrypoint, there is no way to abort the rotation, potentially leading to forced migration to an unintended treasury address. This change provides a defense-in-depth mechanism to revert the protocol to a safe state.
Implementation Details
cancel_treasury_rotationto the contract admin interface.RotationNotPendingtoContractErrorenum to avoid panics.Acceptance Criteria
cancel_treasury_rotationadmin entrypoint #1536.Performance (Hot Path)
env.cost_estimate()): [Insert your measured value here]Checklist
cargo build --target wasm32-unknown-unknown --releasecargo clippy --workspace --all-targets -- -D warnings