Repository navigation
feat: consolidate meal tools with discovery - #195
Merged
Merged
Conversation
- Route meal actions through validated domain dispatch - Preserve privacy, user context, and action retry handling - Cover storage, discovery, history, and schema savings - Document discovery overhead with a reproducible benchmark
|
To use Codex here, create a Codex account and connect to github. |
Owner
Author
|
@codex review |
Repository owner
deleted a comment from
ChiragPatil-WeberShandwick
Oct 23, 2026
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Default missing or null arguments to an empty object - Add zero-argument dispatch tests for meal sync actions - Cover nutrition policy routing with the compact meals tool - Clarify benchmark tool counts for the measured payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the seven model-facing meal/calorie functions with
meals(action, arguments)and read-onlydescribe_action(domain, action). This PR is the meals-only pilot; training, sandbox/browser, and other domain interfaces are unchanged.Why
The model currently receives every meal action schema on each request. Selective discovery reduces the initial meals schema from 820–850 tokenizer-estimated tokens to 188–190, including discovery, approximately 77%.
This does not establish a production cost reduction. Controlled ADK replays reduce total input by approximately 6% when the action can be called directly. Adding a discovery round trip increases input by approximately 43–45% for the two short workflows measured. The benchmark documents the full context and limits. Expansion to other domains remains gated on representative real-model evaluation.
How
arguments.Strict validation intentionally rejects numeric strings, floating-point values, or booleans for integer parameters. The conversation continuation test covers completed old calls/responses; it does not establish resumption of suspended calls to removed leaf-tool names.
Tests
uv run ruff formatuv run ruff checkuv run mypy .uv run pytest --cov=src --cov-report=xml --cov-report=term-missinguv run --with tiktoken==0.12.0 python scripts/benchmark_meal_tools.pybash -n setup.sh entrypoint.shThe full suite passes with 2,237 passed, 1 skipped, and 100% statement and branch coverage. Local Docker was unavailable; the complete deployment-contract job passed in GitHub CI. No live model, paid-provider, production-latency, deployment, or billing claim is made by the scripted benchmark.
Related Issues
No linked issue. This implements the requested meals-domain discovery pilot.