Skip to content

Try running Mooncake linalg tests with CuTensorMaps#461

Merged
kshyatt merged 3 commits into
mainfrom
ksh/mooncuda
Jun 26, 2026
Merged

Try running Mooncake linalg tests with CuTensorMaps#461
kshyatt merged 3 commits into
mainfrom
ksh/mooncuda

Conversation

@kshyatt

@kshyatt kshyatt commented Jun 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt kshyatt marked this pull request as ready for review June 24, 2026 22:48

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For runtime purposes, do you think it makes sense to instead of calling the full test_rule, we could just compare the values with the CPU versions? Or do we care a bit more about the interface tests as well (and can we check only those?)

@kshyatt

kshyatt commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

I think it can make sense to check that the memory is unchanged considering sometimes stuff allocs a new array on CUDA that doesn't on the CPU. Let me see if that is handled in the interface or correctness part of the Mooncake test utils.

@kshyatt

kshyatt commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Looks like the memory address checking happens in the interface tests for reverse rules. Let's then restrict to interface-only on CI, we can keep the full suite when running locally.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt kshyatt merged commit 69d3c3b into main Jun 26, 2026
49 checks passed
@kshyatt kshyatt deleted the ksh/mooncuda branch June 26, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants