Skip to content

Use comprehensions for dims, dual and flip of SumSpace #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KristofferC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use comprehensions for dims, dual and flip of SumSpace #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/vectorspaces/sumspace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,19 @@ Return the type of a `SumSpace` with elements of type `S`.
"""
sumspacetype(::Type{S}) where {S <: ElementarySpace} = SumSpace{S}

TensorKit.dims(S::SumSpace) = map(dim, S.spaces)
# The comprehensions below are deliberate. When the type of `S` is not concrete, a `map` over
# `S.spaces` hits the recursion limit of type inference whenever it is reached from within
# another `map` call, and nothing that calls it is cached (JuliaLang/julia#64862).
TensorKit.dims(S::SumSpace) = [dim(V) for V in S.spaces]
TensorKit.dim(S::SumSpace, n::Int) = dim(S.spaces[n])
TensorKit.dim(S::SumSpace) = sum(dims(S))

TensorKit.isdual(S::SumSpace) = S.dual
TensorKit.dual(S::SumSpace{CartesianSpace}) = SumSpace(map(dual, S.spaces); dual = false)
TensorKit.dual(S::SumSpace) = SumSpace(map(dual, S.spaces); dual = !isdual(S))
TensorKit.dual(S::SumSpace{CartesianSpace}) = SumSpace([dual(V) for V in S.spaces]; dual = false)
TensorKit.dual(S::SumSpace) = SumSpace([dual(V) for V in S.spaces]; dual = !isdual(S))
Base.conj(S::SumSpace) = dual(S)
TensorKit.flip(S::SumSpace{CartesianSpace}) = SumSpace(map(flip, S.spaces); dual = false)
TensorKit.flip(S::SumSpace) = SumSpace(map(flip, S.spaces); dual = isdual(S))
TensorKit.flip(S::SumSpace{CartesianSpace}) = SumSpace([flip(V) for V in S.spaces]; dual = false)
TensorKit.flip(S::SumSpace) = SumSpace([flip(V) for V in S.spaces]; dual = isdual(S))

function TensorKit.hassector(S::SumSpace, s::Sector)
return mapreduce(v -> hassector(v, s), |, S.spaces; init = false)
Expand Down
Loading