Skip to content

Use __EMSCRIPTEN__ instead of EMSCRIPTEN to wrap wasm-specific code - #200

Merged
JohanMabille merged 1 commit into
QuantStack:mainfrom
ianthomas23:correct-emscripten-ifdef
Nov 3, 2026
Merged

JohanMabille merged 1 commit into
QuantStack:mainfrom
ianthomas23:correct-emscripten-ifdef

Conversation

@ianthomas23

Copy link
Copy Markdown
Member

This is required to support emscripten 6.x to build the emscripten-forge package. Using emscripten 4.x either EMSCRIPTEN or __EMSCRIPTEN__ worked for us, with emscripten 6.x it needs to be __EMSCRIPTEN__. The latter has always been the recommended approach, but for some reason I didn't follow that.

There is a workaround for this on Emscripten-forge (emscripten-forge/recipes#8239) which can be removed there after the next git2cpp release.

@ianthomas23 ianthomas23 added maintenance run-wasm-ci Run WASM tests in CI for the current PR labels Nov 3, 2026
@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.78%. Comparing base (29ba827) to head (3b53368).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   88.34%   86.78%   -1.57%     
==========================================
  Files          64       64              
  Lines        3072     3072              
  Branches      376      375       -1     
==========================================
- Hits         2714     2666      -48     
- Misses        358      406      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JohanMabille
JohanMabille merged commit 669bf2c into QuantStack:main Nov 3, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance run-wasm-ci Run WASM tests in CI for the current PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants