Repository navigation
Use __EMSCRIPTEN__ instead of EMSCRIPTEN to wrap wasm-specific code - #200
Merged
JohanMabille merged 1 commit intoNov 3, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 88.34% 86.78% -1.57%
==========================================
Files 64 64
Lines 3072 3072
Branches 376 375 -1
==========================================
- Hits 2714 2666 -48
- Misses 358 406 +48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JohanMabille
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to support emscripten 6.x to build the emscripten-forge package. Using emscripten 4.x either
EMSCRIPTENor__EMSCRIPTEN__worked for us, with emscripten 6.x it needs to be__EMSCRIPTEN__. The latter has always been the recommended approach, but for some reason I didn't follow that.There is a workaround for this on Emscripten-forge (emscripten-forge/recipes#8239) which can be removed there after the next
git2cpprelease.