Repository navigation
Make main build again: install JAX in the environment, finish ak_aiyagari's household rename, add the programming intersphinx key - #297
Merged
Conversation
…26-08-05 sync never delivered myst#706 renamed the household parameter from hh to household on 2026-08-05. Its sync run failed before it could file anything (the anthropic-api-key input was missing that night), so the rename never reached this edition. Today's #290 then synced myst#1078's cells, which use the new name, on top of the old one, and the lecture stopped executing. This brings the nine remaining code lines into line with the English; the lecture's code now has the same 56 hh and the same call sites as the source. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… edition linear_algebra (#280, synced from myst#1054) now carries four {doc}/{ref} targets under the programming: key the English config defines. This edition only had pyprog:, so the build reported four unknown-document warnings, which -W turns into a failure. The zh-cn programming site carries the three labels (numpy_array, numpy_shape_dim, creating_arrays), so the key points there. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟢 Approval recommended
Both fixes are minimal and were verified correct — the function-body rename matches the namedtuple source and leaves only valid global hh references, and the new intersphinx key resolves all four targets confirmed to exist in the linked zh-cn programming edition.
No open issues 🎉
What changed in this PR
This PR repairs two defects that recent automated translation-sync merges introduced onto main, both of which break the -W-gated Jupyter Book build. It restores a successful build without changing any lecture content semantics.
Changes:
- Finishes the
hh→householdhousehold-parameter rename inak_aiyagari.md(nine lines across several@jax.jitfunctions) so execution no longer raisesNameError, matching the English source. - Adds the
programming:intersphinx mapping (pointing at the zh-cn programming edition) in_config.ymlso the fourprogramming:*cross-references inlinear_algebra.mdresolve instead of becoming fatal-Wwarnings.
| File | Description |
|---|---|
lectures/ak_aiyagari.md |
Replaces stale global hh.* references with the local household parameter inside the affected JIT functions, fixing the execution-time NameError. |
lectures/_config.yml |
Adds the programming: intersphinx key mapping to the zh-cn programming edition to resolve four unknown-document cross-references. |
Review effort: Balanced
…stall cell Every other JAX lecture in this edition installs JAX at run time through a !pip install cell that executes. ak_aiyagari and two_computation carry that cell tagged skip-execution, as the English does, because the English runner preinstalls jax[cuda13]. This CI preinstalled nothing, so both lectures failed on import jax. Pinned at 0.11.0 for the lax.fori_loop regression in 0.11.1 (QuantEcon/workspace-lectures#49); the unpinned install cells then leave it in place. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mmcky
changed the title
This was referenced Oct 18, 2026
Closed
The -W gate is blind in ci.yml, and a warning-only cache failure discards a completed execution
#271
Open
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three repairs for defects that today's sync merges put onto
main. All were visible in the merged PRs' own preview logs, but the preview reports build succeeded on notebook execution errors (#271), so they passed.1.
ak_aiyagariandtwo_computationdo not execute: no JAX in CIEvery other JAX lecture in this edition installs JAX at run time through a
!pip install … jaxcell taggedhide-output, which executes. These two lectures carry that cell taggedskip-execution, exactly as the English does, because the English runner preinstallsjax[cuda13]inci.ymlandcache.yml. This edition's CI preinstalls nothing, soimport jaxraisedModuleNotFoundErrorin both. Confirmed by executingtwo_computation's 81 code cells locally with jax 0.11.0: every cell runs and the printed tables match the English.environment.ymlnow installsjax==0.11.0, the pin the programming editions use for thelax.fori_loopregression in 0.11.1 (QuantEcon/workspace-lectures#49). The unpinned!pip install jaxcells elsewhere then find it satisfied and leave it alone.2.
ak_aiyagari'shh→householdrename was never deliveredmyst#706 (2026-08-05) renamed the household parameter. Its sync run failed before it could file anything — the
anthropic-api-keyinput was missing that night — so the rename never reached this edition. #290 (merged today) then synced myst#1078's cells, which usehousehold, on top of the old code: nine code lines in six cells still saidhh. This commit brings them into line with the English; the lecture's code now has the same 56hhoccurrences and call sites as the source, and the remaininghouseholddifferences are in translated prose.3.
linear_algebrahas four unresolved cross-references#280 synced myst#1054, which added four targets under the
programming:intersphinx key the English_config.ymldefines. This edition only hadpyprog:, so Sphinx reported four unknown-document warnings, and-Wmakes those fatal. The key is added, pointing at the zh-cn programming edition, which carries all three labels.Not in this PR (needs the
workflowtoken scope)ci.yml's HTML-step upload looks in_build/html/reportswhile myst-nb writes execution tracebacks to_build/jupyter/reports, so today's failures left no report to download. A one-line patch is with @mmcky. The blind-Wgate itself is #271.🤖 Generated with Claude Code