Repository navigation
Conversation
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The added _toc.yml entries reference four lecture files that do not exist in the repository, which will break the jb build lectures -W CI build.
1 open finding
What changed in this PR
This is an automated translation-sync PR from QuantEcon/lecture-python.myst (source PR #1091). Its stated purpose is to add the "Social Security trust fund depletion" lecture to the Chinese translation book. However, the lecture itself (social_security_depletion.md) failed to translate and is absent, so the only file actually changed is lectures/_toc.yml.
The diff does not match the stated intent: instead of handling social_security_depletion, it adds table-of-contents entries for four unrelated lectures (gallant_tauchen, lucas_prescott_investment, optimal_growth_uncertainty, lq_mean_field_games) whose .md files do not exist in this repository. Since CI builds with jb build lectures -n -W, these ToC references to missing documents will break the build.
Changes:
- Adds four
- file:ToC entries referencing lecture files that are not present inlectures/(build-breaking). - Introduces an incidental trailing-whitespace change on the
统计与信息论caption line (harmless). - Does not add or reference
social_security_depletion, contrary to the PR description.
| File | Description |
|---|---|
| lectures/_toc.yml | Adds ToC entries for four lectures whose source files are missing from the repo, which will fail the Jupyter Book build; does not touch the social_security_depletion lecture named in the PR. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 18, 2026
Closed
mmcky
force-pushed
the
translation-sync-2026-10-16T20-24-18-pr-1091
branch
from
October 21, 2026 23:51
34987e4 to
ec71c89
Compare
Contributor
Author
|
♻️ Automatically rebased after #286 was merged. Overlapping files: The translation content is preserved; only unchanged sections were updated to match the current |
mmcky
added a commit
that referenced
this pull request
Oct 22, 2026
QuantEcon/lecture-python.myst#1091 added social_security_depletion, but its sync failed the structural parity check (the model dropped the leading {raw} header block), filed as QuantEcon/lecture-python.myst#1092, so its sync PR (#296) opened with a _toc.yml change and no lecture. translate init -f social_security_depletion.md at engine v0.29.6 (@v0), claude-sonnet-5, from lecture-python.myst main (9ad04de; the file's last change is 97c5894). The first attempt failed parity the same way and wrote nothing; the second passed. Output as written by the CLI. Its font path is repaired in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Merged
Contributor
Author
|
Closed by GitHub, not by hand: the rebase automation force-pushed this branch when #286 merged (2026-10-21), and the PR closed in the same second (the QuantEcon/action-translation#280 race). The lecture is delivered in #300, on a |
mmcky
added a commit
that referenced
this pull request
Oct 22, 2026
…closed #294 and #296) (#300) * Add gallant_tauchen, as the sync's rebase delivered it at v0.29.6 QuantEcon/lecture-python.myst#1087 added gallant_tauchen; its sync PR, #294, could not build until #286 landed. When #286 merged, the rebase automation re-translated the lecture at @v0 (v0.29.6) and force-pushed the branch, and GitHub shut that PR in the same second (the QuantEcon/action-translation#280 race). The lecture and its state file are taken unchanged from that branch (5d35ce7). Checked against the English source: identical directive sequence (43), math blocks, anchors, the 54 cross-references and citations, headings and code cells; all 23 code cells execute with numerical output identical to the English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * gallant_tauchen: localise the two English figure captions Both mystnb figure captions arrived in English, the QuantEcon/action-translation#255 class. Each uses the lecture's own terms: 公共随机数 and 重新抽取扰动项 (the two curves' descriptions in the text above the figure), 准则函数, 随机波动率 and 收益率. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Seed social_security_depletion, the lecture its sync could not deliver QuantEcon/lecture-python.myst#1091 added social_security_depletion, but its sync failed the structural parity check (the model dropped the leading {raw} header block), filed as QuantEcon/lecture-python.myst#1092, so its sync PR (#296) opened with a _toc.yml change and no lecture. translate init -f social_security_depletion.md at engine v0.29.6 (@v0), claude-sonnet-5, from lecture-python.myst main (9ad04de; the file's last change is 97c5894). The first attempt failed parity the same way and wrote nothing; the second passed. Output as written by the CLI. Its font path is repaired in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * social_security_depletion: font path The engine writes FONTPATH as _fonts/...; this edition keeps the font in lectures/fonts/, so the build would fail with FileNotFoundError. The block is already in the imports cell, and nothing after it resets font.family. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * bib: add the 21 entries the two lectures cite gallant_tauchen cites 17 keys and social_security_depletion 4 that this edition's bibliography lacks. Each is copied verbatim from the source bib and placed after the nearest preceding entry the two files share, keeping the source's order. Additions only; the same 21 keys the sync's rebase added on the two closed PRs' branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * _toc.yml: add gallant_tauchen and social_security_depletion At their source positions: gallant_tauchen after market_diffusion, and social_security_depletion after two_computation, before lq_mean_field_games. Built on main's _toc.yml, so the Chinese part captions are untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * gallant_tauchen state: record the file's last source commit The sync recorded source-sha as f8d7e33, the merge commit of QuantEcon/lecture-python.myst#1087, which was a true merge rather than a squash. translate status compares source-sha with the file's last commit, 648d138 (the PR's head), so it reported this lecture OUTDATED although the source blob is identical at both. Recorded as 648d138, the convention translate init and the other 138 state files in this edition follow; nothing else in the file changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Translation Sync
This PR contains automated translations from QuantEcon/lecture-python.myst.
Source PR
#1091 - Add a lecture on Social Security trust fund depletion
Files Updated
lectures/_toc.ymlThe following new file(s) could not be translated and are absent from this PR. Their entries have been removed from
lectures/_toc.ymlso the target build stays green; the entries return with the files once they are delivered. The error details and recovery steps are in the failure issue this run opens on the source repository.lectures/social_security_depletion.mdDetails
This PR was created automatically by the translation action.