Backport #657 to release-0-22#678
Merged
Merged
Conversation
…e it will be compabitle with generics (#657) Related issue #656 The problem there is when the FunctionType interaces with the IList Generic type it exposed that we're missing a visitor for `is_subseteq_TypeVar` because during lowering we haven't inferred the type yet. (cherry picked from commit 54ea95c)
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports the fix from #657 onto release-0-22, addressing a missing TypeVar subset check for FunctionType during lowering/type inference so FunctionType can interoperate correctly with generic types (e.g., ilist.IList).
Changes:
- Add
FunctionType.is_subseteq_TypeVar()to delegate subset checks to theTypeVarbound. - Add a regression test that exercises a list/IList of
@basicmethods to ensure lowering/type inference completes and runtime behavior matches expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/kirin/ir/attrs/types.py |
Adds FunctionType.is_subseteq_TypeVar so FunctionType <= TypeVar is evaluated via the TypeVar’s bound. |
test/lowering/test_657.py |
Regression test covering the reported lowering/type-inference failure path involving FunctionType and ilist.IList generics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #657 onto the 0.22 release line.
This cherry-picks the FunctionType TypeVar subset fix from main into release-0-22 so it can be included in the next 0.22 patch release.
Validation: