Skip to content

feat(variables): separate secret creation flow#2832

Open
TheoGrandin74 wants to merge 9 commits into
stagingfrom
codex/variables-secret-creation
Open

feat(variables): separate secret creation flow#2832
TheoGrandin74 wants to merge 9 commits into
stagingfrom
codex/variables-secret-creation

Conversation

@TheoGrandin74

@TheoGrandin74 TheoGrandin74 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Split custom variable creation into explicit variable and secret entry points.
  • Added a dedicated secret creation modal state with hidden value by default and a Show value checkbox.
  • Moved Value / As file selection into the creation modal via the shared segmented control.
  • Removed file-specific dropdown entries from custom variable empty states and creation flow actions.
  • Kept these changes scoped to the Custom variables tab and custom variable creation flows.
  • One caveat, the secret value is not hidden when going into the "Value editor" modal
  • Simplified experience on file variable on the path input, the first "/" is filled by default

Screenshots

Two buttons
image

Secret modal
image

Secret as a file modal
image

Validation

  • yarn jest --config libs/domains/variables/feature/jest.config.ts --runTestsByPath libs/domains/variables/feature/src/lib/create-update-variable-modal/create-update-variable-modal.spec.tsx libs/domains/variables/feature/src/lib/variable-list/variable-list.spec.tsx
  • yarn jest --config libs/domains/services/feature/jest.config.ts --runTestsByPath libs/domains/services/feature/src/lib/service-creation-flow/application-container/application-container-variables/step-variables/step-variables.spec.tsx libs/domains/services/feature/src/lib/service-variables-tabs/service-variables-custom-tab.spec.tsx
  • yarn tsc -p libs/domains/services/feature/tsconfig.lib.json --noEmit
  • git diff --check

Known local issue

yarn tsc -p libs/domains/variables/feature/tsconfig.lib.json --noEmit currently fails on unrelated pre-existing errors in libs/domains/clusters/feature/src/lib/cluster-actions/cluster-actions.tsx for unused @ts-expect-error directives.

@nx-cloud

nx-cloud Bot commented Jul 23, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit fc645ac

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 55s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 9s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 38s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-23 10:28:35 UTC

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.70149% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (staging@286393e). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...te-variable-modal/create-update-variable-modal.tsx 76.74% 3 Missing and 7 partials ⚠️
...tainer-variables/step-variables/step-variables.tsx 55.55% 3 Missing and 1 partial ⚠️
...ce-variables-tabs/service-variables-custom-tab.tsx 0.00% 3 Missing ⚠️
...es/feature/src/lib/variable-list/variable-list.tsx 0.00% 3 Missing ⚠️
...iables-action-toolbar/variables-action-toolbar.tsx 0.00% 3 Missing ⚠️
.../lib/flow-create-variable/flow-create-variable.tsx 33.33% 2 Missing ⚠️
...ob-creation-flow/step-variables/step-variables.tsx 0.00% 1 Missing ⚠️
...ponents/inputs/input-text-area/input-text-area.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             staging    #2832   +/-   ##
==========================================
  Coverage           ?   48.15%           
==========================================
  Files              ?     1177           
  Lines              ?    25442           
  Branches           ?     7569           
==========================================
  Hits               ?    12252           
  Misses             ?    11108           
  Partials           ?     2082           
Flag Coverage Δ
unittests 48.15% <59.70%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheoGrandin74
TheoGrandin74 marked this pull request as ready for review July 23, 2026 12:25

@rmnbrd rmnbrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants