feat(variables): separate secret creation flow#2832
Open
TheoGrandin74 wants to merge 9 commits into
Open
Conversation
|
View your CI Pipeline Execution ↗ for commit fc645ac
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2832 +/- ##
==========================================
Coverage ? 48.15%
==========================================
Files ? 1177
Lines ? 25442
Branches ? 7569
==========================================
Hits ? 12252
Misses ? 11108
Partials ? 2082
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TheoGrandin74
marked this pull request as ready for review
July 23, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Show valuecheckbox.Value/As fileselection into the creation modal via the shared segmented control.Screenshots
Two buttons

Secret modal

Secret as a file modal

Validation
yarn jest --config libs/domains/variables/feature/jest.config.ts --runTestsByPath libs/domains/variables/feature/src/lib/create-update-variable-modal/create-update-variable-modal.spec.tsx libs/domains/variables/feature/src/lib/variable-list/variable-list.spec.tsxyarn jest --config libs/domains/services/feature/jest.config.ts --runTestsByPath libs/domains/services/feature/src/lib/service-creation-flow/application-container/application-container-variables/step-variables/step-variables.spec.tsx libs/domains/services/feature/src/lib/service-variables-tabs/service-variables-custom-tab.spec.tsxyarn tsc -p libs/domains/services/feature/tsconfig.lib.json --noEmitgit diff --checkKnown local issue
yarn tsc -p libs/domains/variables/feature/tsconfig.lib.json --noEmitcurrently fails on unrelated pre-existing errors inlibs/domains/clusters/feature/src/lib/cluster-actions/cluster-actions.tsxfor unused@ts-expect-errordirectives.